@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Better error messages for nonexistent CCs, reviewers, etc. in arc
Summary:
The existing message is confusing and might cause people to think
that there is something wrong in the field name, e.g., 'CC' instead
of the value.
Test Plan:
Tested by putting random crap in CC and Reviewers and made sure the
error message was using the new format.
Reviewed By: jungejason
Reviewers: epriestley, jungejason
CC: mdevine, jungejason
Differential Revision: 145
+4
-3
+4
-3
src/applications/differential/parser/commitmessage/DifferentialCommitMessage.php
+4
-3
src/applications/differential/parser/commitmessage/DifferentialCommitMessage.php
···
240
240
$phid = idx($users, $name);
241
241
if (!$phid) {
242
242
throw new DifferentialCommitMessageParserException(
243
-
"Commit message references nonexistent 'Reviewer': ".$name);
243
+
"Commit message references nonexistent 'Reviewer' value '".$name."'");
244
244
}
245
245
$reviewer_phids[] = $phid;
246
246
}
···
251
251
$phid = idx($users, $name);
252
252
if (!$phid) {
253
253
throw new DifferentialCommitMessageParserException(
254
-
"Commit message references nonexistent 'Reviewed by': ".$name);
254
+
"Commit message references nonexistent 'Reviewed by' value '".
255
+
$name."'");
255
256
}
256
257
$reviewed_by_phids[] = $phid;
257
258
}
···
265
266
}
266
267
if (!$phid) {
267
268
throw new DifferentialCommitMessageParserException(
268
-
"Commit message references nonexistent 'CC': ".$name);
269
+
"Commit message references nonexistent 'CC' value '".$name."'");
269
270
}
270
271
$cc_phids[] = $phid;
271
272
}