@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Use javelin_tag(), not phutil_tag(), to render revision blame tooltips properly
Summary: Depends on D19310. Ref T13105. The "meta" value was not populating correctly because this used `phutil_tag()`.
Test Plan: Will verify on `secure`.
Maniphest Tasks: T13105
Differential Revision: https://secure.phabricator.com/D19311
+5
-6
+5
-6
src/applications/diffusion/controller/DiffusionBlameController.php
+5
-6
src/applications/diffusion/controller/DiffusionBlameController.php
···
145
145
'href' => $commit->getURI(),
146
146
'sigil' => 'has-tooltip',
147
147
'meta' => array(
148
-
'tip' => $this->renderCommitTooltip($commit, $handles),
148
+
'tip' => $this->renderCommitTooltip($commit, $handles),
149
149
'align' => 'E',
150
-
'size' => 600,
150
+
'size' => 600,
151
151
),
152
152
),
153
153
$commit->getLocalName());
···
158
158
);
159
159
160
160
if ($revision) {
161
-
$revision_link = phutil_tag(
161
+
$revision_link = javelin_tag(
162
162
'a',
163
163
array(
164
164
'href' => $revision->getURI(),
165
165
'sigil' => 'has-tooltip',
166
166
'meta' => array(
167
-
'tip' => $this->renderRevisionTooltip($revision, $handles),
167
+
'tip' => $this->renderRevisionTooltip($revision, $handles),
168
168
'align' => 'E',
169
-
'size' => 600,
169
+
'size' => 600,
170
170
),
171
171
),
172
172
$revision->getMonogram());
173
-
174
173
175
174
$info = array(
176
175
$info,