recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Add a couple of missing needProperties() Almanac calls

Summary: Fixes T10432. I missed these in making properties non-default.

Test Plan: Diffusion now works again in a cluster configuration.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10432

Differential Revision: https://secure.phabricator.com/D15337

epriestley ee6070a9 76d4e85b

+2
+1
src/applications/diffusion/controller/DiffusionRepositoryCreateController.php
··· 51 51 array( 52 52 'AlmanacClusterRepositoryServiceType', 53 53 )) 54 + ->needProperties(true) 54 55 ->execute(); 55 56 if ($services) { 56 57 // Filter out services which do not permit new allocations.
+1
src/applications/repository/storage/PhabricatorRepository.php
··· 2038 2038 ->setViewer(PhabricatorUser::getOmnipotentUser()) 2039 2039 ->withPHIDs(array($service_phid)) 2040 2040 ->needBindings(true) 2041 + ->needProperties(true) 2041 2042 ->executeOne(); 2042 2043 if (!$service) { 2043 2044 throw new Exception(