@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Initialize variable in Next Step
Test Plan: None.
Reviewers: epriestley
Reviewed By: epriestley
CC: aran, Korvin
Differential Revision: https://secure.phabricator.com/D5020
+4
-6
+4
-6
src/applications/differential/view/DifferentialRevisionDetailView.php
+4
-6
src/applications/differential/view/DifferentialRevisionDetailView.php
···
71
71
switch ($local_vcs) {
72
72
case PhabricatorRepositoryType::REPOSITORY_TYPE_MERCURIAL:
73
73
$bookmark = $this->getDiff()->getBookmark();
74
-
$command = ($bookmark != ''
74
+
$next_step = ($bookmark != ''
75
75
? csprintf('arc land %s', $bookmark)
76
76
: 'arc land');
77
77
break;
78
78
79
79
case PhabricatorRepositoryType::REPOSITORY_TYPE_GIT:
80
80
$branch = $this->getDiff()->getBranch();
81
-
$command = ($branch != ''
81
+
$next_step = ($branch != ''
82
82
? csprintf('arc land %s', $branch)
83
83
: 'arc land');
84
84
break;
85
85
86
86
case PhabricatorRepositoryType::REPOSITORY_TYPE_SVN:
87
-
$command = 'arc commit';
87
+
$next_step = 'arc commit';
88
88
break;
89
89
}
90
-
if ($command) {
91
-
$next_step = phutil_tag('tt', array(), $command);
92
-
}
93
90
}
94
91
if ($next_step) {
92
+
$next_step = phutil_tag('tt', array(), $next_step);
95
93
$properties->addProperty(pht('Next Step'), $next_step);
96
94
}
97
95