+2 -2

src/applications/calendar/parser/ics/PhutilICSWriter.php

reviewed

··· 184 184 } 185 185 186 186 $name = $event->getName(); 187 187 - if (strlen($name)) { 187 187 + if (phutil_nonempty_string($name)) { 188 188 $properties[] = $this->newTextProperty( 189 189 'SUMMARY', 190 190 $name); 191 191 } 192 192 193 193 $description = $event->getDescription(); 194 194 - if (strlen($description)) { 194 194 + if (phutil_nonempty_string($description)) { 195 195 $properties[] = $this->newTextProperty( 196 196 'DESCRIPTION', 197 197 $description);

+4

src/applications/files/format/__tests__/PhabricatorFileStorageFormatTestCase.php

reviewed

··· 45 45 } 46 46 47 47 public function testAES256Storage() { 48 48 + if (!function_exists('openssl_encrypt')) { 49 49 + $this->assertSkipped(pht('No OpenSSL extension available.')); 50 50 + } 51 51 + 48 52 $engine = new PhabricatorTestStorageEngine(); 49 53 50 54 $key_name = 'test.abcd';

+1 -1

src/applications/nuance/github/NuanceGitHubRawEvent.php

reviewed

··· 164 164 $raw = $this->raw; 165 165 166 166 $full = idxv($raw, array('repo', 'name')); 167 167 - if (strlen($full)) { 167 167 + if (phutil_nonempty_string($full)) { 168 168 return $full; 169 169 } 170 170

+1 -1

src/infrastructure/markup/blockrule/PhutilRemarkupListBlockRule.php

reviewed

··· 446 446 } 447 447 448 448 $start_attr = null; 449 449 - if (ctype_digit($starts_at) && $starts_at > 1) { 449 449 + if (ctype_digit(phutil_string_cast($starts_at)) && $starts_at > 1) { 450 450 $start_attr = hsprintf(' start="%d"', $starts_at); 451 451 } 452 452

+2 -2

src/infrastructure/markup/markuprule/PhutilRemarkupDocumentLinkRule.php

reviewed

··· 46 46 47 47 $is_anchor = false; 48 48 if (strncmp($link, '/', 1) == 0) { 49 49 - $base = $engine->getConfig('uri.base'); 49 49 + $base = phutil_string_cast($engine->getConfig('uri.base')); 50 50 $base = rtrim($base, '/'); 51 51 $link = $base.$link; 52 52 } else if (strncmp($link, '#', 1) == 0) { ··· 134 134 135 135 public function markupDocumentLink(array $matches) { 136 136 $uri = trim($matches[1]); 137 137 - $name = trim(idx($matches, 2)); 137 137 + $name = trim(idx($matches, 2, '')); 138 138 139 139 if (!$this->isFlatText($uri)) { 140 140 return $matches[0];