@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Remove another old remarkup engine callsite in Config
Summary: Ref T13189. Summaries do not appear to be meaningfully rendered with Remarkup so just drop the engine. See D19610 for the previous change in this vein.
Test Plan: Viewed config list with option summaries.
Reviewers: amckinley
Maniphest Tasks: T13189
Differential Revision: https://secure.phabricator.com/D19612
+1
-8
+1
-8
src/applications/config/controller/PhabricatorConfigGroupController.php
+1
-8
src/applications/config/controller/PhabricatorConfigGroupController.php
···
60
60
$db_values = mpull($db_values, null, 'getConfigKey');
61
61
}
62
62
63
-
$engine = id(new PhabricatorMarkupEngine())
64
-
->setViewer($this->getRequest()->getUser());
65
-
foreach ($options as $option) {
66
-
$engine->addObject($option, 'summary');
67
-
}
68
-
$engine->process();
69
-
70
63
$list = new PHUIObjectItemListView();
71
64
$list->setBig(true);
72
65
foreach ($options as $option) {
73
-
$summary = $engine->getOutput($option, 'summary');
66
+
$summary = $option->getSummary();
74
67
75
68
$item = id(new PHUIObjectItemView())
76
69
->setHeader($option->getKey())