@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix a fatal when navigating to a Workboard after removing the Workboard menu item
Summary:
See PHI1247. If you remove the Workboard from a project profile menu, then navigate to the URI, we currently fatal when trying to select the "Workboard" item.
Instead, only try to select the item if some matching item is present.
Test Plan:
- Disabled the workboard on a project, navigated to `/board/`, got a sensible page with no navigation item selected instead of a fatal.
- Viewed a normal workboard, saw the correct selection.
Reviewers: amckinley
Reviewed By: amckinley
Differential Revision: https://secure.phabricator.com/D20516
+7
-1
+7
-1
src/applications/project/controller/PhabricatorProjectController.php
+7
-1
src/applications/project/controller/PhabricatorProjectController.php
···
191
191
192
192
$view_list = $engine->newProfileMenuItemViewList();
193
193
194
-
$view_list->setSelectedViewWithItemIdentifier($item_identifier);
194
+
// See PHI1247. If the "Workboard" item is removed from the menu, we will
195
+
// not be able to select it. This can happen if a user removes the item,
196
+
// then manually navigate to the workboard URI (or follows an older link).
197
+
// In this case, just render the menu with no selected item.
198
+
if ($view_list->getViewsWithItemIdentifier($item_identifier)) {
199
+
$view_list->setSelectedViewWithItemIdentifier($item_identifier);
200
+
}
195
201
196
202
$navigation = $view_list->newNavigationView();
197
203