@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Make the hard limit on the number of files showing in Herald emails a constant.
See: <https://github.com/facebook/phabricator/pull/587>
Reviewed by: epriestley
authored by
austinkelleher
and committed by
epriestley
eec05767
c9dc554c
+5
-3
+5
-3
src/applications/repository/worker/PhabricatorRepositoryCommitHeraldWorker.php
+5
-3
src/applications/repository/worker/PhabricatorRepositoryCommitHeraldWorker.php
···
3
3
final class PhabricatorRepositoryCommitHeraldWorker
4
4
extends PhabricatorRepositoryCommitParserWorker {
5
5
6
+
const MAX_FILES_SHOWN_IN_EMAIL = 1000;
7
+
6
8
public function getRequiredLeaseTime() {
7
9
// Herald rules may take a long time to process.
8
10
return phutil_units('4 hours in seconds');
···
138
140
? PhabricatorEnv::getProductionURI('/D'.$revision->getID())
139
141
: 'No revision.';
140
142
141
-
$limit = 1000;
143
+
$limit = self::MAX_FILES_SHOWN_IN_EMAIL;
142
144
$files = $adapter->loadAffectedPaths();
143
145
sort($files);
144
146
if (count($files) > $limit) {
145
147
array_splice($files, $limit);
146
-
$files[] = '(This commit affected more than 1000 files. '.
147
-
'Only 1000 are shown here and additional ones are truncated.)';
148
+
$files[] = '(This commit affected more than '.$limit.' files. '.
149
+
'Only '.$limit.' are shown here and additional ones are truncated.)';
148
150
}
149
151
$files = implode("\n", $files);
150
152