@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Show user profile images on User list
Summary: Ref T4400. Same deal as projects. Tweaked the CSS a touch to make it look better in these views.
Test Plan: Viewed /people/.
Reviewers: chad, btrahan
Reviewed By: btrahan
Subscribers: epriestley, chad
Maniphest Tasks: T4400
Differential Revision: https://secure.phabricator.com/D8571
+15
-12
+3
-3
resources/celerity/map.php
+3
-3
resources/celerity/map.php
···
7
7
return array(
8
8
'names' =>
9
9
array(
10
-
'core.pkg.css' => 'b548faff',
10
+
'core.pkg.css' => '4d72eb6e',
11
11
'core.pkg.js' => '264721e1',
12
12
'darkconsole.pkg.js' => 'ca8671ce',
13
13
'differential.pkg.css' => 'cb97e095',
···
141
141
'rsrc/css/phui/phui-info-panel.css' => '27ea50a1',
142
142
'rsrc/css/phui/phui-list.css' => '2edb76cf',
143
143
'rsrc/css/phui/phui-object-box.css' => 'ce92d8ec',
144
-
'rsrc/css/phui/phui-object-item-list-view.css' => 'a8131782',
144
+
'rsrc/css/phui/phui-object-item-list-view.css' => 'bde610d2',
145
145
'rsrc/css/phui/phui-pinboard-view.css' => '4b346c2a',
146
146
'rsrc/css/phui/phui-property-list-view.css' => 'dbf53b12',
147
147
'rsrc/css/phui/phui-remarkup-preview.css' => '19ad512b',
···
758
758
'phui-info-panel-css' => '27ea50a1',
759
759
'phui-list-view-css' => '2edb76cf',
760
760
'phui-object-box-css' => 'ce92d8ec',
761
-
'phui-object-item-list-view-css' => 'a8131782',
761
+
'phui-object-item-list-view-css' => 'bde610d2',
762
762
'phui-pinboard-view-css' => '4b346c2a',
763
763
'phui-property-list-view-css' => 'dbf53b12',
764
764
'phui-remarkup-preview-css' => '19ad512b',
+2
-4
src/applications/people/controller/PhabricatorPeopleListController.php
+2
-4
src/applications/people/controller/PhabricatorPeopleListController.php
···
53
53
$email = pht('Unverified');
54
54
}
55
55
56
-
$user_handle = new PhabricatorObjectHandle();
57
-
$user_handle->setImageURI($user->loadProfileImageURI());
58
-
59
56
$item = new PHUIObjectItemView();
60
57
$item->setHeader($user->getFullName())
61
58
->setHref('/p/'.$user->getUsername().'/')
62
59
->addAttribute(hsprintf('%s %s',
63
60
phabricator_date($user->getDateCreated(), $viewer),
64
61
phabricator_time($user->getDateCreated(), $viewer)))
65
-
->addAttribute($email);
62
+
->addAttribute($email)
63
+
->setImageURI($user->getProfileImageURI());
66
64
67
65
if ($user->getIsDisabled()) {
68
66
$item->addIcon('disable', pht('Disabled'));
+2
-1
src/applications/people/query/PhabricatorPeopleSearchEngine.php
+2
-1
src/applications/people/query/PhabricatorPeopleSearchEngine.php
···
26
26
27
27
public function buildQueryFromSavedQuery(PhabricatorSavedQuery $saved) {
28
28
$query = id(new PhabricatorPeopleQuery())
29
-
->needPrimaryEmail(true);
29
+
->needPrimaryEmail(true)
30
+
->needProfileImage(true);
30
31
31
32
$usernames = $saved->getParameter('usernames', array());
32
33
if ($usernames) {
+6
-2
src/applications/people/storage/PhabricatorUser.php
+6
-2
src/applications/people/storage/PhabricatorUser.php
···
32
32
protected $isEmailVerified = 0;
33
33
protected $isApproved = 0;
34
34
35
-
private $profileImage = null;
35
+
private $profileImage = self::ATTACHABLE;
36
36
private $profile = null;
37
37
private $status = self::ATTACHABLE;
38
38
private $preferences = null;
···
647
647
return $this;
648
648
}
649
649
650
+
public function getProfileImageURI() {
651
+
return $this->assertAttached($this->profileImage);
652
+
}
653
+
650
654
public function loadProfileImageURI() {
651
-
if ($this->profileImage) {
655
+
if ($this->profileImage && $this->profileImage !== self::ATTACHABLE) {
652
656
return $this->profileImage;
653
657
}
654
658
+2
-2
webroot/rsrc/css/phui/phui-object-item-list-view.css
+2
-2
webroot/rsrc/css/phui/phui-object-item-list-view.css
···
572
572
.phui-object-item-image {
573
573
width: 50px;
574
574
height: 50px;
575
-
margin: 4px 4px 4px 8px;
575
+
margin: 4px 4px 4px 4px;
576
576
position: absolute;
577
577
background-color: {$lightbluebackground};
578
578
}
···
582
582
}
583
583
584
584
.phui-object-item-with-image .phui-object-item-content-box {
585
-
margin-left: 58px;
585
+
margin-left: 54px;
586
586
}