recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix PHP 8.1 "strlen(null)" exception in Feed setting up MFA

Summary:
`strlen()` was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

```
ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/auth/xaction/PhabricatorAuthFactorProviderNameTransaction.php:20]
```

Closes T15992

Test Plan: After applying the changes, go to http://phorge.localhost/feed/transactions/ and check the entries related to setting up an MFA provider.

Reviewers: O1 Blessed Committers, slip, avivey

Reviewed By: O1 Blessed Committers, slip, avivey

Subscribers: slip, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15992

Differential Revision: https://we.phorge.it/D25867

Andre Klapper ef3e0a75 964b1d4b

+2 -2
+2 -2
src/applications/auth/xaction/PhabricatorAuthFactorProviderNameTransaction.php
··· 17 17 $old = $this->getOldValue(); 18 18 $new = $this->getNewValue(); 19 19 20 - if (!strlen($old)) { 20 + if (!phutil_nonempty_string($old)) { 21 21 return pht( 22 22 '%s named this provider %s.', 23 23 $this->renderAuthor(), 24 24 $this->renderNewValue()); 25 - } else if (!strlen($new)) { 25 + } else if (!phutil_nonempty_string($new)) { 26 26 return pht( 27 27 '%s removed the name (%s) of this provider.', 28 28 $this->renderAuthor(),