@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Add a "Rule Detail" link to Herald email

Summary:
See PHI285. Ref T13130. After recent changes Herald sends email about rules, but the mail doesn't currently actually include a link to the rule.

Include a link for consistency and ease-of-use.

Test Plan: Edited a rule, looked at the resulting mail, saw a link to the rule.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13130

Differential Revision: https://secure.phabricator.com/D19413

+18
+14
src/applications/herald/editor/HeraldRuleEditor.php
··· 137 137 return pht('[Herald]'); 138 138 } 139 139 140 + 141 + protected function buildMailBody( 142 + PhabricatorLiskDAO $object, 143 + array $xactions) { 144 + 145 + $body = parent::buildMailBody($object, $xactions); 146 + 147 + $body->addLinkSection( 148 + pht('RULE DETAIL'), 149 + PhabricatorEnv::getProductionURI($object->getURI())); 150 + 151 + return $body; 152 + } 153 + 140 154 }
+4
src/applications/herald/storage/HeraldRule.php
··· 254 254 return 'H'.$this->getID(); 255 255 } 256 256 257 + public function getURI() { 258 + return '/'.$this->getMonogram(); 259 + } 260 + 257 261 258 262 /* -( Repetition Policies )------------------------------------------------ */ 259 263