@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Allow "MFA Required" objects to be edited without MFA if the edit is only creating inverse edges
Summary:
Depends on D19900. Ref T13222. See PHI873. When an object requires MFA, we currently require MFA for every transaction.
This includes some ambiguous cases like "unsubscribe", but also includes "mention", which seems like clearly bad behavior.
Allow an "MFA" object to be the target of mentions, "edit child tasks", etc.
Test Plan:
- Mentioned an MFA object elsewhere (no MFA prompt).
- Made an MFA object a subtask of a non-MFA object (no MFA prompt).
- Tried to edit an MFA object normally (still got an MFA prompt).
Reviewers: amckinley
Reviewed By: amckinley
Maniphest Tasks: T13222
Differential Revision: https://secure.phabricator.com/D19901
+7
+7
src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
+7
src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
···
4893
4893
return $xactions;
4894
4894
}
4895
4895
4896
+
// If the user is mentioning an MFA object on another object or creating
4897
+
// a relationship like "parent" or "child" to this object, we allow the
4898
+
// edit to move forward without requiring MFA.
4899
+
if ($this->getIsInverseEdgeEditor()) {
4900
+
return $xactions;
4901
+
}
4902
+
4896
4903
$template = $object->getApplicationTransactionTemplate();
4897
4904
4898
4905
$mfa_xaction = id(clone $template)