@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Wordsmith the timezone selection UX
Summary:
Ref T3025.
- Show current zone to make the current vs new more clear.
- Tweak some text.
Test Plan: {F1656534}
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T3025
Differential Revision: https://secure.phabricator.com/D15965
+11
-3
+10
-2
src/applications/settings/controller/PhabricatorSettingsTimezoneController.php
+10
-2
src/applications/settings/controller/PhabricatorSettingsTimezoneController.php
···
81
81
$guess = 'ignore';
82
82
}
83
83
84
+
$current_zone = $viewer->getTimezoneIdentifier();
85
+
$current_zone = phutil_tag('strong', array(), $current_zone);
86
+
84
87
$form = id(new AphrontFormView())
85
88
->appendChild(
89
+
id(new AphrontFormMarkupControl())
90
+
->setLabel(pht('Current Setting'))
91
+
->setValue($current_zone))
92
+
->appendChild(
86
93
id(new AphrontFormSelectControl())
87
94
->setName('timezone')
88
-
->setLabel(pht('Timezone'))
95
+
->setLabel(pht('New Setting'))
89
96
->setOptions($options)
90
97
->setValue($guess));
91
98
92
99
return $this->newDialog()
93
100
->setTitle(pht('Adjust Timezone'))
101
+
->setWidth(AphrontDialogView::WIDTH_FORM)
94
102
->appendParagraph(
95
103
pht(
96
104
'Your browser timezone (%s) differs from your profile timezone '.
···
100
108
$this->formatOffset($server_offset)))
101
109
->appendForm($form)
102
110
->addCancelButton(pht('Cancel'))
103
-
->addSubmitButton(pht('Submit'));
111
+
->addSubmitButton(pht('Change Timezone'));
104
112
}
105
113
106
114
private function formatOffset($offset) {
+1
-1
src/view/page/PhabricatorStandardPageView.php
+1
-1
src/view/page/PhabricatorStandardPageView.php
···
241
241
'uri' => '/settings/timezone/',
242
242
'message' => pht(
243
243
'Your browser timezone setting differs from the timezone '.
244
-
'setting in your profile.'),
244
+
'setting in your profile, click to reconcile.'),
245
245
'ignoreKey' => $ignore_key,
246
246
'ignore' => $ignore,
247
247
));