@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
fixing file issue -- files can be deleted
+7
-1
+7
-1
src/applications/conpherence/query/ConpherenceThreadQuery.php
+7
-1
src/applications/conpherence/query/ConpherenceThreadQuery.php
···
194
194
$conpherence_files = array();
195
195
$files_authors = array();
196
196
foreach ($conpherence->getFilePHIDs() as $curr_phid) {
197
-
$conpherence_files[$curr_phid] = $files[$curr_phid];
197
+
$curr_file = idx($files, $curr_phid);
198
+
if (!$curr_file) {
199
+
// this file was deleted or user doesn't have permission to see it
200
+
// this is generally weird
201
+
continue;
202
+
}
203
+
$conpherence_files[$curr_phid] = $curr_file;
198
204
// some files don't have authors so be careful
199
205
$current_author = null;
200
206
$current_author_phid = idx($file_author_phids, $curr_phid);