@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix an issue with "nextPage()" on worker trigger queries
Ref T13266. We never page these queries, and previously never reached the
"nextPage()" method. The call order changed recently and this method is now
reachable. For now, just no-op it rather than throwing.
+5
-1
+5
-1
src/infrastructure/daemon/workers/query/PhabricatorWorkerTriggerQuery.php
+5
-1
src/infrastructure/daemon/workers/query/PhabricatorWorkerTriggerQuery.php
···
70
70
protected function nextPage(array $page) {
71
71
// NOTE: We don't implement paging because we don't currently ever need
72
72
// it and paging ORDER_EXECUTION is a hassle.
73
-
throw new PhutilMethodNotImplementedException();
73
+
74
+
// (Before T13266, we raised an exception here, but since "nextPage()" is
75
+
// now called even if we don't page we can't do that anymore. Just do
76
+
// nothing instead.)
77
+
return null;
74
78
}
75
79
76
80
protected function loadPage() {