@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Update passphrase edit UI
Summary: Updates creating credentials
Test Plan: create some notes
Reviewers: epriestley
Reviewed By: epriestley
Spies: Korvin
Differential Revision: https://secure.phabricator.com/D18570
+5
-23
-2
src/applications/herald/controller/HeraldRuleController.php
-2
src/applications/herald/controller/HeraldRuleController.php
···
238
238
? pht('Edit Herald Rule: %s', $rule->getName())
239
239
: pht('Create Herald Rule: %s', idx($content_type_map, $content_type));
240
240
241
-
$icon = $rule->getID() ? 'fa-pencil' : 'fa-plus-square';
242
-
243
241
$form_box = id(new PHUIObjectBoxView())
244
242
->setHeaderText($title)
245
243
->setBackground(PHUIObjectBoxView::WHITE_CONFIG)
+2
-7
src/applications/passphrase/controller/PassphraseCredentialCreateController.php
+2
-7
src/applications/passphrase/controller/PassphraseCredentialCreateController.php
···
52
52
$crumbs->setBorder(true);
53
53
54
54
$box = id(new PHUIObjectBoxView())
55
-
->setHeaderText(pht('Credential'))
55
+
->setHeaderText($title)
56
56
->setFormErrors($errors)
57
-
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
57
+
->setBackground(PHUIObjectBoxView::WHITE_CONFIG)
58
58
->setForm($form);
59
59
60
-
$header = id(new PHUIHeaderView())
61
-
->setHeader($title)
62
-
->setHeaderIcon('fa-plus-square');
63
-
64
60
$view = id(new PHUITwoColumnView())
65
-
->setHeader($header)
66
61
->setFooter($box);
67
62
68
63
return $this->newPage()
+3
-14
src/applications/passphrase/controller/PassphraseCredentialEditController.php
+3
-14
src/applications/passphrase/controller/PassphraseCredentialEditController.php
···
250
250
->setLabel(pht('Description'))
251
251
->setValue($v_desc))
252
252
->appendChild(
253
-
id(new AphrontFormMarkupControl())
254
-
->setLabel(pht('Credential Type'))
255
-
->setValue($type->getCredentialTypeName()))
256
-
->appendChild(
257
253
id(new AphrontFormDividerControl()))
258
254
->appendControl(
259
255
id(new AphrontFormPolicyControl())
···
322
318
$crumbs->setBorder(true);
323
319
324
320
if ($is_new) {
325
-
$title = pht('Create New Credential');
321
+
$title = pht('New Credential: %s', $type->getCredentialTypeName());
326
322
$crumbs->addTextCrumb(pht('Create'));
327
323
$cancel_uri = $this->getApplicationURI();
328
-
$header_icon = 'fa-plus-square';
329
324
} else {
330
325
$title = pht('Edit Credential: %s', $credential->getName());
331
326
$crumbs->addTextCrumb(
···
333
328
'/K'.$credential->getID());
334
329
$crumbs->addTextCrumb(pht('Edit'));
335
330
$cancel_uri = '/K'.$credential->getID();
336
-
$header_icon = 'fa-pencil';
337
331
}
338
332
339
333
if ($request->isAjax()) {
···
356
350
->addCancelButton($cancel_uri));
357
351
358
352
$box = id(new PHUIObjectBoxView())
359
-
->setHeaderText(pht('Credential'))
353
+
->setHeaderText($title)
360
354
->setFormErrors($errors)
361
355
->setValidationException($validation_exception)
362
-
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
356
+
->setBackground(PHUIObjectBoxView::WHITE_CONFIG)
363
357
->setForm($form);
364
358
365
-
$header = id(new PHUIHeaderView())
366
-
->setHeader($title)
367
-
->setHeaderIcon($header_icon);
368
-
369
359
$view = id(new PHUITwoColumnView())
370
-
->setHeader($header)
371
360
->setFooter(array(
372
361
$box,
373
362
));