recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Conpherenece - improve performance by not fetching data as often from D12347

Summary: Turns out the pertinent views don't use this data anyway. Additonally, change the remaining pathway to fetch 15% of the rows it fetched in D12347. Fixes T7815.

Test Plan: clicked around and things worked. my instance always feels snappy though

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T7815

Differential Revision: https://secure.phabricator.com/D12399

Bob Trahan f12839ff d096b9c1

+3 -5
-1
src/applications/conpherence/controller/ConpherenceColumnViewController.php
··· 16 16 $latest_conpherences = id(new ConpherenceThreadQuery()) 17 17 ->setViewer($user) 18 18 ->withPHIDs($conpherence_phids) 19 - ->needTransactions(true) 20 19 ->needParticipantCache(true) 21 20 ->execute(); 22 21 $latest_conpherences = mpull($latest_conpherences, null, 'getPHID');
-1
src/applications/conpherence/controller/ConpherenceListController.php
··· 138 138 $conpherences = id(new ConpherenceThreadQuery()) 139 139 ->setViewer($user) 140 140 ->withPHIDs($conpherence_phids) 141 - ->needTransactions(true) 142 141 ->needParticipantCache(true) 143 142 ->execute(); 144 143
+1
src/applications/conpherence/controller/ConpherenceNotificationPanelController.php
··· 18 18 ->setViewer($user) 19 19 ->withPHIDs(array_keys($participant_data)) 20 20 ->needTransactions(true) 21 + ->setTransactionLimit(3 * 5) 21 22 ->needParticipantCache(true) 22 23 ->execute(); 23 24 }
+2 -2
src/applications/conpherence/controller/ConpherenceUpdateController.php
··· 380 380 $need_widget_data = false; 381 381 $need_transactions = false; 382 382 $need_participant_cache = true; 383 - $need_transactions = true; 384 383 switch ($action) { 385 384 case ConpherenceUpdateActions::METADATA: 386 - break; 387 385 case ConpherenceUpdateActions::LOAD: 386 + $need_transactions = true; 388 387 break; 389 388 case ConpherenceUpdateActions::MESSAGE: 390 389 case ConpherenceUpdateActions::ADD_PERSON: 390 + $need_transactions = true; 391 391 $need_widget_data = true; 392 392 break; 393 393 case ConpherenceUpdateActions::REMOVE_PERSON:
-1
src/applications/conpherence/query/ConpherenceThreadSearchEngine.php
··· 27 27 28 28 public function buildQueryFromSavedQuery(PhabricatorSavedQuery $saved) { 29 29 $query = id(new ConpherenceThreadQuery()) 30 - ->needTransactions(true) 31 30 ->needParticipantCache(true); 32 31 33 32 $participant_phids = $saved->getParameter('participantPHIDs', array());