@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix a straggling issue with cursor changes impacting Conpherence thread indexing
Summary: Ref T13266. Caught one more of these "directly setting afterID" issues in the logs.
Test Plan: Ran `bin/search index --type ConpherenceThread` before and after changes. Before: fatal about a direct call. After: clean index rebuild.
Reviewers: amckinley
Reviewed By: amckinley
Maniphest Tasks: T13266
Differential Revision: https://secure.phabricator.com/D20341
+7
-4
+7
-4
src/applications/conpherence/engineextension/ConpherenceThreadIndexEngineExtension.php
+7
-4
src/applications/conpherence/engineextension/ConpherenceThreadIndexEngineExtension.php
···
51
51
ConpherenceThread $thread,
52
52
ConpherenceTransaction $xaction) {
53
53
54
-
$previous = id(new ConpherenceTransactionQuery())
54
+
$pager = id(new AphrontCursorPagerView())
55
+
->setPageSize(1)
56
+
->setAfterID($xaction->getID());
57
+
58
+
$previous_xactions = id(new ConpherenceTransactionQuery())
55
59
->setViewer($this->getViewer())
56
60
->withObjectPHIDs(array($thread->getPHID()))
57
61
->withTransactionTypes(array(PhabricatorTransactions::TYPE_COMMENT))
58
-
->setAfterID($xaction->getID())
59
-
->setLimit(1)
60
-
->executeOne();
62
+
->executeWithCursorPager($pager);
63
+
$previous = head($previous_xactions);
61
64
62
65
$index = id(new ConpherenceIndex())
63
66
->setThreadPHID($thread->getPHID())