@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Add an "isDone" flag to "transaction.search" for Differential inline comments
Summary: See PHI1684. Expose the published state of the "Done" checkbox to the API.
Test Plan: Made API calls on a comment in all four states, got correct published states via the API in all cases.
Differential Revision: https://secure.phabricator.com/D21059
+9
+9
src/applications/differential/xaction/DifferentialRevisionInlineTransaction.php
+9
src/applications/differential/xaction/DifferentialRevisionInlineTransaction.php
···
38
38
$changeset = $data[$comment->getChangesetID()];
39
39
$diff = $changeset->getDiff();
40
40
41
+
$is_done = false;
42
+
switch ($comment->getFixedState()) {
43
+
case PhabricatorInlineCommentInterface::STATE_DONE:
44
+
case PhabricatorInlineCommentInterface::STATE_UNDRAFT:
45
+
$is_done = true;
46
+
break;
47
+
}
48
+
41
49
return array(
42
50
'diff' => array(
43
51
'id' => (int)$diff->getID(),
···
47
55
'line' => (int)$comment->getLineNumber(),
48
56
'length' => (int)($comment->getLineLength() + 1),
49
57
'replyToCommentPHID' => $comment->getReplyToCommentPHID(),
58
+
'isDone' => $is_done,
50
59
);
51
60
}
52
61