@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix an out-of-order issue in the new update-during-publish behavior
Summary:
Ref T13552. The Herald field "Accepted Differential revision" (and similar fields) depend on the task/revision update steps running before Herald executes.
Herald currently executes first, so it never sees associated revisions. Swap this order.
Test Plan: Published a commit, got a clean parse/import. Will test with production rules ("Cowboy Commits").
Maniphest Tasks: T13552
Differential Revision: https://secure.phabricator.com/D21468
+8
-1
+8
-1
src/applications/repository/worker/PhabricatorRepositoryCommitPublishWorker.php
+8
-1
src/applications/repository/worker/PhabricatorRepositoryCommitPublishWorker.php
···
67
67
return;
68
68
}
69
69
70
-
$this->applyTransactions($viewer, $repository, $commit);
70
+
// NOTE: Close revisions and tasks before applying transactions, because
71
+
// we want a side effect of closure (the commit being associated with
72
+
// a revision) to occur before a side effect of transactions (Herald
73
+
// executing). The close methods queue tasks for the actual updates to
74
+
// commits/revisions, so those won't occur until after the commit gets
75
+
// transactions.
71
76
72
77
$this->closeRevisions($viewer, $commit);
73
78
$this->closeTasks($viewer, $commit);
79
+
80
+
$this->applyTransactions($viewer, $repository, $commit);
74
81
}
75
82
76
83
private function applyTransactions(