@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Return `$this` from setter methods

Summary: Return `$this` from setter methods for consistency. I started writing a [[https://secure.phabricator.com/differential/diff/32506/ | linter rule]] to detect this, but I don't think it is trivial to do this properly.

Test Plan: Eyeball it.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D13422

+15
+1
src/applications/aphlict/management/PhabricatorAphlictManagementWorkflow.php
··· 88 88 89 89 final protected function setDebug($debug) { 90 90 $this->debug = $debug; 91 + return $this; 91 92 } 92 93 93 94 public static function requireExtensions() {
+1
src/applications/differential/parser/DifferentialChangesetParser.php
··· 257 257 258 258 $this->originalLeft = $left; 259 259 $this->originalRight = $right; 260 + return $this; 260 261 } 261 262 262 263 public function diffOriginals() {
+1
src/applications/diviner/atom/DivinerAtom.php
··· 370 370 371 371 public function setProperty($key, $value) { 372 372 $this->properties[$key] = $value; 373 + return $this; 373 374 } 374 375 375 376 public function getProperties() {
+1
src/applications/legalpad/editor/LegalpadDocumentEditor.php
··· 15 15 16 16 private function setIsContribution($is_contribution) { 17 17 $this->isContribution = $is_contribution; 18 + return $this; 18 19 } 19 20 20 21 private function isContribution() {
+1
src/applications/metamta/view/PhabricatorMetaMTAMailBody.php
··· 20 20 21 21 public function setViewer($viewer) { 22 22 $this->viewer = $viewer; 23 + return $this; 23 24 } 24 25 25 26 /* -( Composition )-------------------------------------------------------- */
+1
src/applications/paste/view/PasteEmbedView.php
··· 24 24 25 25 public function setLines($lines) { 26 26 $this->lines = $lines; 27 + return $this; 27 28 } 28 29 29 30 public function render() {
+2
src/applications/releeph/editor/ReleephRequestTransactionalEditor.php
··· 302 302 'RQ'.$id)); 303 303 break; 304 304 } 305 + 306 + return $this; 305 307 } 306 308 307 309 }
+1
src/applications/releeph/field/specification/ReleephFieldSpecification.php
··· 110 110 $this->getRequiredStorageKey()); 111 111 $this->validate($value); 112 112 $this->setValue($value); 113 + return $this; 113 114 } 114 115 115 116
+1
src/applications/releeph/field/specification/ReleephLevelFieldSpecification.php
··· 118 118 pht("Unknown %s level name '%s'", $label, $name)); 119 119 } 120 120 $this->setValue($level); 121 + return $this; 121 122 } 122 123 123 124 private $nameMap = array();
+2
src/applications/repository/engine/PhabricatorRepositoryRefEngine.php
··· 438 438 PhabricatorWorker::scheduleTask($class, $data); 439 439 } 440 440 } 441 + 442 + return $this; 441 443 } 442 444 443 445
+2
src/applications/search/engine/PhabricatorApplicationSearchEngine.php
··· 513 513 PhabricatorProjectObjectHasProjectEdgeType::EDGECONST, 514 514 $constraints); 515 515 } 516 + 517 + return $this; 516 518 } 517 519 518 520
+1
src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldPHIDs.php
··· 42 42 } 43 43 } 44 44 $this->setFieldValue($value); 45 + return $this; 45 46 } 46 47 47 48 public function readApplicationSearchValueFromRequest(