recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

When requesting file data, make "Range: bytes=0-" work correctly

Summary: Ref T12219. Chrome can send requests with a "Range: bytes=0-" header, which just means "the whole file", but we don't respond correctly because of a `null` vs `0` issue.

Test Plan: Sent a raw `bytes=0-` request, saw a proper resonse.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12219

Differential Revision: https://secure.phabricator.com/D17627

epriestley f2a26b26 d1a971e2

+1 -1
+1 -1
src/aphront/response/AphrontFileResponse.php
··· 94 94 array('Accept-Ranges', 'bytes'), 95 95 ); 96 96 97 - if ($this->rangeMin || $this->rangeMax) { 97 + if ($this->rangeMin !== null || $this->rangeMax !== null) { 98 98 $len = $this->getContentLength(); 99 99 $min = $this->rangeMin; 100 100