@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Set project's ObjectName to its PHID when it doesn't have a hashtag
Summary: Fixes T12659. Previously this would lead to an error when trying to run `arc diff` on a revision that had a milestone as a reviewer (or any non-octothorpe'd Object Name)
Test Plan: Followed repro steps in T12659 and didn't get the error described. Also clicked around and didn't notice any obvious regressions in projects or differential
Reviewers: epriestley, #blessed_reviewers
Reviewed By: epriestley, #blessed_reviewers
Subscribers: Korvin, yelirekim
Maniphest Tasks: T12659
Differential Revision: https://secure.phabricator.com/D17807
+4
+4
src/applications/project/phid/PhabricatorProjectProjectPHIDType.php
+4
src/applications/project/phid/PhabricatorProjectProjectPHIDType.php
···
47
47
$handle->setObjectName('#'.$slug);
48
48
$handle->setURI("/tag/{$slug}/");
49
49
} else {
50
+
// We set the name to the project's PHID to avoid a parse error when a
51
+
// project has no hashtag (as is the case with milestones by default).
52
+
// See T12659 for more details
53
+
$handle->setCommandLineObjectName($project->getPHID());
50
54
$handle->setURI("/project/view/{$id}/");
51
55
}
52
56