@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
A few Macro bugs
Summary: Consistent look for panels, test for mobile, forms consistency
Test Plan: test Macro on web and iOS sim
Reviewers: epriestley, btrahan
Reviewed By: epriestley
CC: aran, Korvin
Differential Revision: https://secure.phabricator.com/D5959
+6
-9
+4
-9
src/applications/macro/controller/PhabricatorMacroEditController.php
+4
-9
src/applications/macro/controller/PhabricatorMacroEditController.php
···
156
156
157
157
$form
158
158
->setEncType('multipart/form-data')
159
+
->setFlexible(true)
159
160
->appendChild(
160
161
id(new AphrontFormTextControl())
161
162
->setLabel(pht('Name'))
···
219
220
220
221
if ($macro->getID()) {
221
222
$title = pht('Edit Image Macro');
222
-
$crumb = pht('Edit');
223
+
$crumb = pht('Edit Macro');
223
224
224
225
$crumbs->addCrumb(
225
226
id(new PhabricatorCrumbView())
···
227
228
->setName(pht('Macro "%s"', $macro->getName())));
228
229
} else {
229
230
$title = pht('Create Image Macro');
230
-
$crumb = pht('Create');
231
+
$crumb = pht('Create Macro');
231
232
}
232
233
233
234
$crumbs->addCrumb(
···
266
267
$upload = array($upload_header, $upload_form);
267
268
}
268
269
269
-
$panel = new AphrontPanelView();
270
-
$panel->setHeader(pht('Create New Macro'));
271
-
$panel->setNoBackground();
272
-
$panel->appendChild($form);
273
-
$panel->setWidth(AphrontPanelView::WIDTH_FORM);
274
-
275
270
return $this->buildApplicationPage(
276
271
array(
277
272
$crumbs,
278
273
$error_view,
279
-
$panel,
274
+
$form,
280
275
$upload,
281
276
),
282
277
array(
+1
src/applications/macro/controller/PhabricatorMacroListController.php
+1
src/applications/macro/controller/PhabricatorMacroListController.php