@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Don't report zero grep results as error
Test Plan: Grepped for non-existing string.
Reviewers: epriestley
Reviewed By: epriestley
CC: aran, Korvin
Differential Revision: https://secure.phabricator.com/D5776
+6
-3
+6
-3
src/applications/diffusion/controller/DiffusionBrowseController.php
+6
-3
src/applications/diffusion/controller/DiffusionBrowseController.php
···
209
209
}
210
210
211
211
} catch (CommandException $ex) {
212
-
return id(new AphrontErrorView())
213
-
->setTitle(pht('Search Error'))
214
-
->appendChild($ex->getStderr());
212
+
$stderr = $ex->getStderr();
213
+
if ($stderr != '') {
214
+
return id(new AphrontErrorView())
215
+
->setTitle(pht('Search Error'))
216
+
->appendChild($stderr);
217
+
}
215
218
}
216
219
217
220
$results = array_slice($results, $page);