@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Use Array.prototype.slice in JX.$A
Summary: Being bold. I think it is fine to do this in 2011.
Test Plan: Run the new specs.
Reviewers: mroch, tomo, epriestley
Reviewed By: epriestley
Subscribers: chad, epriestley, aran
Differential Revision: https://secure.phabricator.com/D835
+2
-9
+2
-9
webroot/rsrc/externals/javelin/core/util.js
+2
-9
webroot/rsrc/externals/javelin/core/util.js
···
48
48
*
49
49
* @group util
50
50
*/
51
-
JX.$A = function(mysterious_arraylike_object) {
52
-
// NOTE: This avoids the Array.slice() trick because some bizarre COM object
53
-
// I dug up somewhere was freaking out when I tried to do it and it made me
54
-
// very upset, so do not replace this with Array.slice() cleverness.
55
-
var r = [];
56
-
for (var ii = 0; ii < mysterious_arraylike_object.length; ii++) {
57
-
r.push(mysterious_arraylike_object[ii]);
58
-
}
59
-
return r;
51
+
JX.$A = function(object) {
52
+
return Array.prototype.slice.call(object);
60
53
};
61
54
62
55