@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Use more consistent diff coloration in unified diffs
Summary:
Ref T13151. See PHI701. Unified diffs are currently missing the logic to apply the "old-full" and "new-full" classes, which results in a too-light coloration for fully added or removed lines.
Make this logic consistent with the two-up renderer so we use the same colors in both.
Test Plan: Viewed diffs and swapped between 1-up and 2-up renderers, now saw the same coloration.
Reviewers: amckinley
Reviewed By: amckinley
Maniphest Tasks: T13151
Differential Revision: https://secure.phabricator.com/D19482
+10
-2
+10
-2
src/applications/differential/render/DifferentialChangesetOneUpRenderer.php
+10
-2
src/applications/differential/render/DifferentialChangesetOneUpRenderer.php
···
68
68
$cells = array();
69
69
if ($is_old) {
70
70
if ($p['htype']) {
71
-
$class = 'left old';
71
+
if (empty($p['oline'])) {
72
+
$class = 'left old old-full';
73
+
} else {
74
+
$class = 'left old';
75
+
}
72
76
$aural = $aural_minus;
73
77
} else {
74
78
$class = 'left';
···
106
110
$cells[] = $no_coverage;
107
111
} else {
108
112
if ($p['htype']) {
109
-
$class = 'right new';
113
+
if (empty($p['oline'])) {
114
+
$class = 'right new new-full';
115
+
} else {
116
+
$class = 'right new';
117
+
}
110
118
$cells[] = phutil_tag('th', array('class' => $class));
111
119
$aural = $aural_plus;
112
120
} else {