@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix some method signatures
Summary: Fix some method signatures so that arguments with default values are at the end of the argument list (see D12418).
Test Plan: Eyeballed the callsites.
Reviewers: epriestley, #blessed_reviewers, hach-que
Reviewed By: epriestley, #blessed_reviewers, hach-que
Subscribers: hach-que, Korvin, epriestley
Differential Revision: https://secure.phabricator.com/D12782
+13
-16
+6
-4
src/applications/celerity/CelerityStaticResourceResponse.php
+6
-4
src/applications/celerity/CelerityStaticResourceResponse.php
···
33
33
}
34
34
35
35
/**
36
-
* Register a behavior for initialization. NOTE: if $config is empty,
37
-
* a behavior will execute only once even if it is initialized multiple times.
38
-
* If $config is nonempty, the behavior will be invoked once for each config.
36
+
* Register a behavior for initialization.
37
+
*
38
+
* NOTE: If `$config` is empty, a behavior will execute only once even if it
39
+
* is initialized multiple times. If `$config` is nonempty, the behavior will
40
+
* be invoked once for each configuration.
39
41
*/
40
42
public function initBehavior(
41
43
$behavior,
42
44
array $config = array(),
43
-
$source_name) {
45
+
$source_name = null) {
44
46
45
47
$this->requireResource('javelin-behavior-'.$behavior, $source_name);
46
48
+1
-1
src/applications/drydock/blueprint/DrydockBlueprintImplementation.php
+1
-1
src/applications/drydock/blueprint/DrydockBlueprintImplementation.php
+2
-2
src/applications/people/storage/PhabricatorUserLog.php
+2
-2
src/applications/people/storage/PhabricatorUserLog.php
+3
-3
src/applications/phragment/storage/PhragmentFragment.php
+3
-3
src/applications/phragment/storage/PhragmentFragment.php
···
78
78
public static function createFromFile(
79
79
PhabricatorUser $viewer,
80
80
PhabricatorFile $file = null,
81
-
$path,
82
-
$view_policy,
83
-
$edit_policy) {
81
+
$path = null,
82
+
$view_policy = null,
83
+
$edit_policy = null) {
84
84
85
85
$fragment = id(new PhragmentFragment());
86
86
$fragment->setPath($path);