@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix implicitly nullable parameter declarations for PHP 8.4
Summary:
Implicitly nullable parameter declarations are deprecated in PHP 8.4:
https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated
The proposed syntax was introduced in PHP 7.1.
This patch is a followup on top of D25814.
Refs T15935
Test Plan:
* Try to view a task in the browser
* Try to run `./bin/auth recover` on the CLI
* Try to browse projects in the browser
* Try to create a new project without a name in the browser
Reviewers: O1 Blessed Committers, chris
Reviewed By: O1 Blessed Committers, chris
Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno
Maniphest Tasks: T15935
Differential Revision: https://we.phorge.it/D25816
+10
-10
+4
-4
src/applications/auth/engine/PhabricatorAuthSessionEngine.php
+4
-4
src/applications/auth/engine/PhabricatorAuthSessionEngine.php
···
334
334
*/
335
335
public function terminateLoginSessions(
336
336
PhabricatorUser $user,
337
-
PhutilOpaqueEnvelope $except_session = null) {
337
+
?PhutilOpaqueEnvelope $except_session = null) {
338
338
339
339
$sessions = id(new PhabricatorAuthSessionQuery())
340
340
->setViewer($user)
···
955
955
*/
956
956
public function getOneTimeLoginURI(
957
957
PhabricatorUser $user,
958
-
PhabricatorUserEmail $email = null,
958
+
?PhabricatorUserEmail $email = null,
959
959
$type = self::ONETIME_RESET,
960
960
$force_full_session = false) {
961
961
···
1003
1003
*/
1004
1004
public function loadOneTimeLoginKey(
1005
1005
PhabricatorUser $user,
1006
-
PhabricatorUserEmail $email = null,
1006
+
?PhabricatorUserEmail $email = null,
1007
1007
$key = null) {
1008
1008
1009
1009
$key_hash = $this->getOneTimeLoginKeyHash($user, $email, $key);
···
1031
1031
*/
1032
1032
private function getOneTimeLoginKeyHash(
1033
1033
PhabricatorUser $user,
1034
-
PhabricatorUserEmail $email = null,
1034
+
?PhabricatorUserEmail $email = null,
1035
1035
$key = null) {
1036
1036
1037
1037
$parts = array(
+1
-1
src/applications/project/controller/PhabricatorProjectController.php
+1
-1
src/applications/project/controller/PhabricatorProjectController.php
+1
-1
src/applications/search/engine/PhabricatorProfileMenuItemViewList.php
+1
-1
src/applications/search/engine/PhabricatorProfileMenuItemViewList.php
+2
-2
src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
+2
-2
src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
···
5026
5026
}
5027
5027
5028
5028
final protected function newSubEditor(
5029
-
PhabricatorApplicationTransactionEditor $template = null) {
5029
+
?PhabricatorApplicationTransactionEditor $template = null) {
5030
5030
$editor = $this->newEditorCopy($template);
5031
5031
5032
5032
$editor->parentEditor = $this;
···
5036
5036
}
5037
5037
5038
5038
private function newEditorCopy(
5039
-
PhabricatorApplicationTransactionEditor $template = null) {
5039
+
?PhabricatorApplicationTransactionEditor $template = null) {
5040
5040
if ($template === null) {
5041
5041
$template = newv(get_class($this), array());
5042
5042
}
+1
-1
src/applications/transactions/error/PhabricatorApplicationTransactionValidationError.php
+1
-1
src/applications/transactions/error/PhabricatorApplicationTransactionValidationError.php