@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
When cancelling an inline comment edit, exit the edit state after the response arrives
Summary: Ref T13513. This fixes a bug where clicking a line number, then clicking "Cancel" causes the paths panel to briefly update with an extra inline comment counted on the file.
Test Plan:
- Clicked a line number.
- Typed some text.
- Clicked "Cancel".
- Before patch: paths panel flashes "1".
- After patch: paths panel stays stable.
Maniphest Tasks: T13513
Differential Revision: https://secure.phabricator.com/D21253
+7
-8
+6
-6
resources/celerity/map.php
+6
-6
resources/celerity/map.php
···
13
13
'core.pkg.js' => '0efaf0ac',
14
14
'dark-console.pkg.js' => '187792c2',
15
15
'differential.pkg.css' => 'b042ee8b',
16
-
'differential.pkg.js' => '79dfae6e',
16
+
'differential.pkg.js' => '5d560bda',
17
17
'diffusion.pkg.css' => '42c75c37',
18
18
'diffusion.pkg.js' => 'a98c0bf7',
19
19
'maniphest.pkg.css' => '35995d6d',
···
381
381
'rsrc/js/application/dashboard/behavior-dashboard-tab-panel.js' => '0116d3e8',
382
382
'rsrc/js/application/diff/DiffChangeset.js' => 'b6bb0240',
383
383
'rsrc/js/application/diff/DiffChangesetList.js' => '1e8658bb',
384
-
'rsrc/js/application/diff/DiffInline.js' => '9bb6f2ad',
384
+
'rsrc/js/application/diff/DiffInline.js' => '734d3c33',
385
385
'rsrc/js/application/diff/DiffPathView.js' => '8207abf9',
386
386
'rsrc/js/application/diff/DiffTreeView.js' => '5d83623b',
387
387
'rsrc/js/application/differential/behavior-diff-radios.js' => '925fe8cd',
···
776
776
'phabricator-dashboard-css' => '5a205b9d',
777
777
'phabricator-diff-changeset' => 'b6bb0240',
778
778
'phabricator-diff-changeset-list' => '1e8658bb',
779
-
'phabricator-diff-inline' => '9bb6f2ad',
779
+
'phabricator-diff-inline' => '734d3c33',
780
780
'phabricator-diff-path-view' => '8207abf9',
781
781
'phabricator-diff-tree-view' => '5d83623b',
782
782
'phabricator-drag-and-drop-file-upload' => '4370900d',
···
1565
1565
'javelin-util',
1566
1566
'javelin-reactor-node-calmer',
1567
1567
),
1568
+
'734d3c33' => array(
1569
+
'javelin-dom',
1570
+
),
1568
1571
'73ecc1f8' => array(
1569
1572
'javelin-behavior',
1570
1573
'javelin-behavior-device',
···
1791
1794
'9aae2b66' => array(
1792
1795
'javelin-install',
1793
1796
'javelin-util',
1794
-
),
1795
-
'9bb6f2ad' => array(
1796
-
'javelin-dom',
1797
1797
),
1798
1798
'9c01e364' => array(
1799
1799
'javelin-behavior',
+1
-2
webroot/rsrc/js/application/diff/DiffInline.js
+1
-2
webroot/rsrc/js/application/diff/DiffInline.js
···
736
736
this._drawUneditRows(text);
737
737
}
738
738
739
-
this.setEditing(false);
740
-
741
739
// If this was an empty box and we typed some text and then hit cancel,
742
740
// don't show the empty concrete inline.
743
741
if (!this._originalText) {
···
764
762
},
765
763
766
764
_onCancelResponse: function(response) {
765
+
this.setEditing(false);
767
766
this.setLoading(false);
768
767
769
768
// If the comment was empty when we started editing it (there's no