recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix PHP 8.1 "strlen(null)" exception when DarkConsole is enabled

Summary:
`strlen()` was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

This is not visible in the web user interface, only in the PHP error log.

Closes T15344

Test Plan: Applied this change, on top of D25165 locally applied, and no stacktrace is printed anymore in the PHP error log.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15344

Differential Revision: https://we.phorge.it/D25188

Andre Klapper f4d28119 b0044bad

+2 -1
+2 -1
src/applications/console/controller/DarkConsoleController.php
··· 25 25 return $response; 26 26 } 27 27 28 + // This should be '0' when closed and '1' when opened 28 29 $visible = $request->getStr('visible'); 29 - if (strlen($visible)) { 30 + if (phutil_nonempty_string($visible)) { 30 31 $this->writeDarkConsoleSetting( 31 32 PhabricatorDarkConsoleVisibleSetting::SETTINGKEY, 32 33 (int)$visible);