@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
When reclaiming an "Abandoned + Draft" revision, return it to "Draft", not "Needs Review"
Summary: Depends on D19287. Ref T13110. Currently, "Abandon" and then "Reclaim" moves you out of "Draft" without setting the "Should Broadcast" flag. Keep these revisions in draft instead.
Test Plan: Reclaimed an abandoned + draft revision, got a draft revision instead of a "needs review + nonbroadcast" revision (which isn't a meaningful state).
Maniphest Tasks: T13110
Differential Revision: https://secure.phabricator.com/D19288
+6
-2
+6
-2
src/applications/differential/xaction/DifferentialRevisionReclaimTransaction.php
+6
-2
src/applications/differential/xaction/DifferentialRevisionReclaimTransaction.php
···
48
48
}
49
49
50
50
public function applyInternalEffects($object, $value) {
51
-
$status_review = DifferentialRevisionStatus::NEEDS_REVIEW;
52
-
$object->setModernRevisionStatus($status_review);
51
+
if ($object->getShouldBroadcast()) {
52
+
$new_status = DifferentialRevisionStatus::NEEDS_REVIEW;
53
+
} else {
54
+
$new_status = DifferentialRevisionStatus::DRAFT;
55
+
}
56
+
$object->setModernRevisionStatus($new_status);
53
57
}
54
58
55
59
protected function validateAction($object, PhabricatorUser $viewer) {