@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Put "workflow" on Dashboard edit links when they're disabled
Summary:
Depends on D20367. Ref T13272. When an edit action is disabled, we add "workflow" so that the "You can't do this" message renders in a dialog instead of a separate page.
These actions are implemented in a nonstandard way; standardize them.
Test Plan: Clicked both actions as a user who could take them (got normal behavior); and as a user who could not (got permissions dialog errors).
Reviewers: amckinley
Reviewed By: amckinley
Maniphest Tasks: T13272
Differential Revision: https://secure.phabricator.com/D20368
+4
-3
+4
-3
src/applications/dashboard/controller/dashboard/PhabricatorDashboardViewController.php
+4
-3
src/applications/dashboard/controller/dashboard/PhabricatorDashboardViewController.php
···
79
79
->setName(pht('Edit Dashboard'))
80
80
->setIcon('fa-pencil')
81
81
->setHref($this->getApplicationURI("edit/{$id}/"))
82
-
->setDisabled(!$can_edit));
82
+
->setDisabled(!$can_edit)
83
+
->setWorkflow(!$can_edit));
83
84
84
85
$curtain->addAction(
85
86
id(new PhabricatorActionView())
···
95
96
->setIcon('fa-check')
96
97
->setHref($this->getApplicationURI("archive/{$id}/"))
97
98
->setDisabled(!$can_edit)
98
-
->setWorkflow($can_edit));
99
+
->setWorkflow(true));
99
100
} else {
100
101
$curtain->addAction(
101
102
id(new PhabricatorActionView())
···
103
104
->setIcon('fa-ban')
104
105
->setHref($this->getApplicationURI("archive/{$id}/"))
105
106
->setDisabled(!$can_edit)
106
-
->setWorkflow($can_edit));
107
+
->setWorkflow(true));
107
108
}
108
109
109
110
return $curtain;