@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Remove Differential "View Policy" field
Summary: Ref T11114. Obsoleted by EditEngine.
Test Plan: Edited the view policy of a revision.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T11114
Differential Revision: https://secure.phabricator.com/D17082
-53
-2
src/__phutil_library_map__.php
-2
src/__phutil_library_map__.php
···
582
582
'DifferentialUnitStatus' => 'applications/differential/constants/DifferentialUnitStatus.php',
583
583
'DifferentialUnitTestResult' => 'applications/differential/constants/DifferentialUnitTestResult.php',
584
584
'DifferentialUpdateRevisionConduitAPIMethod' => 'applications/differential/conduit/DifferentialUpdateRevisionConduitAPIMethod.php',
585
-
'DifferentialViewPolicyField' => 'applications/differential/customfield/DifferentialViewPolicyField.php',
586
585
'DiffusionAuditorDatasource' => 'applications/diffusion/typeahead/DiffusionAuditorDatasource.php',
587
586
'DiffusionAuditorFunctionDatasource' => 'applications/diffusion/typeahead/DiffusionAuditorFunctionDatasource.php',
588
587
'DiffusionAuditorsAddAuditorsHeraldAction' => 'applications/diffusion/herald/DiffusionAuditorsAddAuditorsHeraldAction.php',
···
5247
5246
'DifferentialUnitStatus' => 'Phobject',
5248
5247
'DifferentialUnitTestResult' => 'Phobject',
5249
5248
'DifferentialUpdateRevisionConduitAPIMethod' => 'DifferentialConduitAPIMethod',
5250
-
'DifferentialViewPolicyField' => 'DifferentialCoreCustomField',
5251
5249
'DiffusionAuditorDatasource' => 'PhabricatorTypeaheadCompositeDatasource',
5252
5250
'DiffusionAuditorFunctionDatasource' => 'PhabricatorTypeaheadCompositeDatasource',
5253
5251
'DiffusionAuditorsAddAuditorsHeraldAction' => 'DiffusionAuditorsHeraldAction',
-1
src/applications/differential/config/PhabricatorDifferentialConfigOptions.php
-1
src/applications/differential/config/PhabricatorDifferentialConfigOptions.php
-50
src/applications/differential/customfield/DifferentialViewPolicyField.php
-50
src/applications/differential/customfield/DifferentialViewPolicyField.php
···
1
-
<?php
2
-
3
-
final class DifferentialViewPolicyField
4
-
extends DifferentialCoreCustomField {
5
-
6
-
public function getFieldKey() {
7
-
return 'differential:view-policy';
8
-
}
9
-
10
-
public function getFieldName() {
11
-
return pht('View Policy');
12
-
}
13
-
14
-
public function getFieldDescription() {
15
-
return pht('Controls visibility.');
16
-
}
17
-
18
-
protected function readValueFromRevision(
19
-
DifferentialRevision $revision) {
20
-
return $revision->getViewPolicy();
21
-
}
22
-
23
-
public function readValueFromRequest(AphrontRequest $request) {
24
-
$this->setValue($request->getStr($this->getFieldKey()));
25
-
}
26
-
27
-
public function renderEditControl(array $handles) {
28
-
$viewer = $this->getViewer();
29
-
$revision = $this->getObject();
30
-
31
-
$policies = id(new PhabricatorPolicyQuery())
32
-
->setViewer($viewer)
33
-
->setObject($revision)
34
-
->execute();
35
-
36
-
return id(new AphrontFormPolicyControl())
37
-
->setUser($viewer)
38
-
->setCapability(PhabricatorPolicyCapability::CAN_VIEW)
39
-
->setPolicyObject($revision)
40
-
->setPolicies($policies)
41
-
->setName($this->getFieldKey())
42
-
->setValue($this->getValue())
43
-
->setError($this->getFieldError());
44
-
}
45
-
46
-
public function getApplicationTransactionType() {
47
-
return PhabricatorTransactions::TYPE_VIEW_POLICY;
48
-
}
49
-
50
-
}