recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Return 404 instead of undefined variable error when trying to edit a non-existent form

Summary: E.g. https://phab-01.wmflabs.org/transactions/editengine/transactions.editengine.config/view/13/

Test Plan:
* Go to /transactions/editengine/transactions.editengine.config/view/1000000/
* Observe error
* Apply patch
* Observe 404

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: epriestley

Differential Revision: https://secure.phabricator.com/D15307

authored by

Alex Monk and committed by
epriestley f557fc9c 82ca92a9

+2
+2
src/applications/transactions/controller/PhabricatorEditEngineController.php
··· 70 70 ->executeOne(); 71 71 if ($config) { 72 72 $engine = $config->getEngine(); 73 + } else { 74 + return null; 73 75 } 74 76 75 77 if (!$engine->isEngineConfigurable()) {