@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

[Redesign] Phriction UI Updates, Header tweaks

Summary: Ref T8099, walked through Phriction, updated PHUIHeader for more consistent layouts.

Test Plan: Test Phriction Document, Heirarchy, History, Diffs.

Reviewers: btrahan, epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T8099

Differential Revision: https://secure.phabricator.com/D13084

+44 -31
+19 -19
resources/celerity/map.php
··· 7 7 */ 8 8 return array( 9 9 'names' => array( 10 - 'core.pkg.css' => 'db211713', 10 + 'core.pkg.css' => '3bcbbf9c', 11 11 'core.pkg.js' => 'fbf1d615', 12 12 'darkconsole.pkg.js' => 'e7393ebb', 13 - 'differential.pkg.css' => '7d01bee8', 13 + 'differential.pkg.css' => 'f89b49b6', 14 14 'differential.pkg.js' => '8c98ce21', 15 15 'diffusion.pkg.css' => '385e85b3', 16 16 'diffusion.pkg.js' => '0115b37c', ··· 58 58 'rsrc/css/application/dashboard/dashboard.css' => 'eb458607', 59 59 'rsrc/css/application/diff/inline-comment-summary.css' => 'eb5f8e8c', 60 60 'rsrc/css/application/differential/add-comment.css' => 'c47f8c40', 61 - 'rsrc/css/application/differential/changeset-view.css' => 'd9ff1f23', 61 + 'rsrc/css/application/differential/changeset-view.css' => '582b23ab', 62 62 'rsrc/css/application/differential/core.css' => '7ac3cabc', 63 63 'rsrc/css/application/differential/phui-inline-comment.css' => 'aa16f165', 64 64 'rsrc/css/application/differential/results-table.css' => '181aa9d9', ··· 109 109 'rsrc/css/application/tokens/tokens.css' => '3d0f239e', 110 110 'rsrc/css/application/uiexample/example.css' => '528b19de', 111 111 'rsrc/css/core/core.css' => 'bbc7187b', 112 - 'rsrc/css/core/remarkup.css' => 'ea91b3ee', 112 + 'rsrc/css/core/remarkup.css' => '67a4ee29', 113 113 'rsrc/css/core/syntax.css' => '6b7b24d9', 114 114 'rsrc/css/core/z-index.css' => '63689f49', 115 115 'rsrc/css/diviner/diviner-shared.css' => '38813222', ··· 129 129 'rsrc/css/phui/phui-box.css' => 'a5bb366d', 130 130 'rsrc/css/phui/phui-button.css' => 'b995182d', 131 131 'rsrc/css/phui/phui-crumbs-view.css' => 'ce840ec2', 132 - 'rsrc/css/phui/phui-document.css' => '88f0c90b', 132 + 'rsrc/css/phui/phui-document.css' => '08f33f08', 133 133 'rsrc/css/phui/phui-feed-story.css' => '92f55311', 134 134 'rsrc/css/phui/phui-fontkit.css' => 'b664ac96', 135 135 'rsrc/css/phui/phui-form-view.css' => 'a0e8f168', 136 136 'rsrc/css/phui/phui-form.css' => 'f535f938', 137 - 'rsrc/css/phui/phui-header-view.css' => '7716c613', 137 + 'rsrc/css/phui/phui-header-view.css' => '125a540c', 138 138 'rsrc/css/phui/phui-icon.css' => '88ba9081', 139 139 'rsrc/css/phui/phui-image-mask.css' => '5a8b09c8', 140 140 'rsrc/css/phui/phui-info-panel.css' => '27ea50a1', 141 141 'rsrc/css/phui/phui-info-view.css' => '33e54618', 142 142 'rsrc/css/phui/phui-list.css' => 'e448b6ba', 143 - 'rsrc/css/phui/phui-object-box.css' => '92f2ddcf', 143 + 'rsrc/css/phui/phui-object-box.css' => 'c57e6647', 144 144 'rsrc/css/phui/phui-object-item-list-view.css' => '29ded459', 145 145 'rsrc/css/phui/phui-pinboard-view.css' => '55b27bc3', 146 146 'rsrc/css/phui/phui-property-list-view.css' => '1baf23eb', ··· 150 150 'rsrc/css/phui/phui-tag-view.css' => '402691cc', 151 151 'rsrc/css/phui/phui-text.css' => 'cf019f54', 152 152 'rsrc/css/phui/phui-timeline-view.css' => '07a1bd0f', 153 - 'rsrc/css/phui/phui-workboard-view.css' => '720efdde', 154 - 'rsrc/css/phui/phui-workpanel-view.css' => '01b6e9c6', 153 + 'rsrc/css/phui/phui-workboard-view.css' => '0cac51a4', 154 + 'rsrc/css/phui/phui-workpanel-view.css' => '4bdc2562', 155 155 'rsrc/css/sprite-login.css' => 'a3526809', 156 156 'rsrc/css/sprite-menu.css' => 'ab8f6356', 157 157 'rsrc/css/sprite-projects.css' => 'b0d9e24f', ··· 502 502 'conpherence-transaction-css' => '42a457f6', 503 503 'conpherence-update-css' => '1099a660', 504 504 'conpherence-widget-pane-css' => '77096740', 505 - 'differential-changeset-view-css' => 'd9ff1f23', 505 + 'differential-changeset-view-css' => '582b23ab', 506 506 'differential-core-view-css' => '7ac3cabc', 507 507 'differential-inline-comment-editor' => 'd4c87bf4', 508 508 'differential-results-table-css' => '181aa9d9', ··· 724 724 'phabricator-phtize' => 'd254d646', 725 725 'phabricator-prefab' => '6920d200', 726 726 'phabricator-profile-css' => 'cb6f56b7', 727 - 'phabricator-remarkup-css' => 'ea91b3ee', 727 + 'phabricator-remarkup-css' => '67a4ee29', 728 728 'phabricator-search-results-css' => 'ce897fb9', 729 729 'phabricator-shaped-request' => '7cbe244b', 730 730 'phabricator-side-menu-view-css' => '4f2cd343', ··· 763 763 'phui-calendar-list-css' => 'c1c7f338', 764 764 'phui-calendar-month-css' => '476be7e0', 765 765 'phui-crumbs-view-css' => 'ce840ec2', 766 - 'phui-document-view-css' => '88f0c90b', 766 + 'phui-document-view-css' => '08f33f08', 767 767 'phui-feed-story-css' => '92f55311', 768 768 'phui-font-icon-base-css' => '3dad2ae3', 769 769 'phui-fontkit-css' => 'b664ac96', 770 770 'phui-form-css' => 'f535f938', 771 771 'phui-form-view-css' => 'a0e8f168', 772 - 'phui-header-view-css' => '7716c613', 772 + 'phui-header-view-css' => '125a540c', 773 773 'phui-icon-view-css' => '88ba9081', 774 774 'phui-image-mask-css' => '5a8b09c8', 775 775 'phui-info-panel-css' => '27ea50a1', 776 776 'phui-info-view-css' => '33e54618', 777 777 'phui-inline-comment-view-css' => 'aa16f165', 778 778 'phui-list-view-css' => 'e448b6ba', 779 - 'phui-object-box-css' => '92f2ddcf', 779 + 'phui-object-box-css' => 'c57e6647', 780 780 'phui-object-item-list-view-css' => '29ded459', 781 781 'phui-pinboard-view-css' => '55b27bc3', 782 782 'phui-property-list-view-css' => '1baf23eb', ··· 786 786 'phui-tag-view-css' => '402691cc', 787 787 'phui-text-css' => 'cf019f54', 788 788 'phui-timeline-view-css' => '07a1bd0f', 789 - 'phui-workboard-view-css' => '720efdde', 790 - 'phui-workpanel-view-css' => '01b6e9c6', 789 + 'phui-workboard-view-css' => '0cac51a4', 790 + 'phui-workpanel-view-css' => '4bdc2562', 791 791 'phuix-action-list-view' => 'b5c256b8', 792 792 'phuix-action-view' => '8cf6d262', 793 793 'phuix-dropdown-menu' => 'bd4c8dca', ··· 1210 1210 'javelin-vector', 1211 1211 'javelin-request', 1212 1212 'javelin-util', 1213 + ), 1214 + '582b23ab' => array( 1215 + 'phui-inline-comment-view-css', 1213 1216 ), 1214 1217 58562350 => array( 1215 1218 'javelin-dom', ··· 1843 1846 'javelin-dom', 1844 1847 'javelin-util', 1845 1848 'phabricator-shaped-request', 1846 - ), 1847 - 'd9ff1f23' => array( 1848 - 'phui-inline-comment-view-css', 1849 1849 ), 1850 1850 'dbbf48b6' => array( 1851 1851 'javelin-behavior',
+2 -1
src/applications/phriction/controller/PhrictionDiffController.php
··· 126 126 $title = pht('Version %s vs %s', $l, $r); 127 127 128 128 $header = id(new PHUIHeaderView()) 129 - ->setHeader($title); 129 + ->setHeader($title) 130 + ->setTall(true); 130 131 131 132 $crumbs->addTextCrumb($title, $request->getRequestURI()); 132 133
+4 -2
src/applications/phriction/controller/PhrictionDocumentController.php
··· 422 422 $header = id(new PHUIHeaderView()) 423 423 ->setHeader(pht('Document Hierarchy')); 424 424 425 - return id(new PHUIDocumentView()) 425 + $box = id(new PHUIObjectBoxView()) 426 426 ->setHeader($header) 427 427 ->appendChild(phutil_tag( 428 428 'div', 429 429 array( 430 - 'class' => 'phabricator-remarkup', 430 + 'class' => 'phabricator-remarkup mlt mlb', 431 431 ), 432 432 phutil_tag( 433 433 'ul', ··· 435 435 'class' => 'remarkup-list', 436 436 ), 437 437 $list))); 438 + 439 + return phutil_tag_div('phui-document-box', $box); 438 440 } 439 441 440 442 private function renderChildDocumentLink(array $info) {
+4 -4
src/applications/phriction/controller/PhrictionHistoryController.php
··· 148 148 PhrictionDocument::getSlugURI($document->getSlug(), 'history')); 149 149 150 150 $header = new PHUIHeaderView(); 151 - $header->setHeader(pht('Document History for %s', 152 - phutil_tag( 151 + $header->setHeader(phutil_tag( 153 152 'a', 154 153 array('href' => PhrictionDocument::getSlugURI($document->getSlug())), 155 - head($history)->getTitle()))); 154 + head($history)->getTitle())); 155 + $header->setSubheader(pht('Document History')); 156 156 157 157 $obj_box = id(new PHUIObjectBoxView()) 158 158 ->setHeader($header) 159 - ->appendChild($list) 159 + ->setObjectList($list) 160 160 ->appendChild($pager); 161 161 162 162 return $this->buildApplicationPage(
+1
webroot/rsrc/css/application/differential/changeset-view.css
··· 267 267 font-size: 15px; 268 268 padding: 2px 0 12px 12px; 269 269 line-height: 18px; 270 + font-weight: 500; 270 271 } 271 272 272 273 .device-phone .differential-changeset h1 {
+4
webroot/rsrc/css/core/remarkup.css
··· 109 109 margin: 4px 0 4px 24px; 110 110 } 111 111 112 + .phabricator-remarkup .remarkup-list-item { 113 + line-height: 1.55em; 114 + } 115 + 112 116 .phabricator-remarkup li.phantom-item, 113 117 .phabricator-remarkup li.phantom-item { 114 118 list-style-type: none;
+5
webroot/rsrc/css/phui/phui-document.css
··· 23 23 margin: 16px auto; 24 24 } 25 25 26 + .device-desktop .phui-document-box { 27 + max-width: 996px; 28 + margin: 24px auto; 29 + } 30 + 26 31 .device-desktop .phui-document-fluid .phui-document-view { 27 32 max-width: none; 28 33 margin: 16px;
+2 -2
webroot/rsrc/css/phui/phui-header-view.css
··· 72 72 color: #000; 73 73 font-size: 15px; 74 74 font-weight: 500; 75 - line-height: 20px; 75 + line-height: 24px; 76 76 } 77 77 78 78 .device-phone .phui-header-header { ··· 128 128 display: inline-block; 129 129 background-repeat: no-repeat; 130 130 background-size: 100%; 131 - border: 1px solid {$lightblueborder}; 131 + border: 1px solid rgba(0,0,0,.1); 132 132 width: 50px; 133 133 height: 50px; 134 134 }
-1
webroot/rsrc/css/phui/phui-object-box.css
··· 93 93 .phui-object-box-hidden-content { 94 94 background: {$lightgreybackground}; 95 95 border-bottom: 1px solid {$thinblueborder}; 96 - margin-bottom: 4px; 97 96 } 98 97 99 98 .phui-object-box.phui-object-box-collapsed .phui-object-box-hidden-content {
+1 -1
webroot/rsrc/css/phui/phui-workboard-view.css
··· 107 107 padding: 8px; 108 108 } 109 109 110 - .project-board-header .phui-header-view { 110 + .project-board-header .phui-header-header { 111 111 font-size: 18px; 112 112 } 113 113
+2 -1
webroot/rsrc/css/phui/phui-workpanel-view.css
··· 10 10 padding: 8px; 11 11 } 12 12 13 - .phui-workpanel-view .phui-header-shell .phui-header-view { 13 + .phui-workpanel-view .phui-header-shell .phui-header-header { 14 14 font-size: 14px; 15 + line-height: 18px; 15 16 color: {$darkbluetext}; 16 17 } 17 18