@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Simplify Countdown mailtags
Summary: These were a little silly, simplify them
Test Plan: New countdown, edit preferences, etc.
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Differential Revision: https://secure.phabricator.com/D13888
+10
-14
+4
-6
src/applications/countdown/editor/PhabricatorCountdownEditor.php
+4
-6
src/applications/countdown/editor/PhabricatorCountdownEditor.php
···
147
147
148
148
public function getMailTagsMap() {
149
149
return array(
150
-
PhabricatorCountdownTransaction::MAILTAG_TITLE =>
151
-
pht('Someone changes the countdown title.'),
152
-
PhabricatorCountdownTransaction::MAILTAG_DESCRIPTION =>
153
-
pht('Someone changes the countdown description.'),
154
-
PhabricatorCountdownTransaction::MAILTAG_EPOCH =>
155
-
pht('Someone changes the countdown end date.'),
150
+
PhabricatorCountdownTransaction::MAILTAG_DETAILS =>
151
+
pht('Someone changes the countdown details.'),
152
+
PhabricatorCountdownTransaction::MAILTAG_COMMENT =>
153
+
pht('Someone comments on a countdown.'),
156
154
PhabricatorCountdownTransaction::MAILTAG_OTHER =>
157
155
pht('Other countdown activity not listed above occurs.'),
158
156
);
+6
-8
src/applications/countdown/storage/PhabricatorCountdownTransaction.php
+6
-8
src/applications/countdown/storage/PhabricatorCountdownTransaction.php
···
7
7
const TYPE_EPOCH = 'countdown:epoch';
8
8
const TYPE_DESCRIPTION = 'countdown:description';
9
9
10
-
const MAILTAG_TITLE = 'countdown:title';
11
-
const MAILTAG_EPOCH = 'countdown:epoch';
12
-
const MAILTAG_DESCRIPTION = 'countdown:description';
10
+
const MAILTAG_DETAILS = 'countdown:details';
11
+
const MAILTAG_COMMENT = 'countdown:comment';
13
12
const MAILTAG_OTHER = 'countdown:other';
14
13
15
14
public function getApplicationName() {
···
135
134
$tags = parent::getMailTags();
136
135
137
136
switch ($this->getTransactionType()) {
137
+
case PhabricatorTransactions::TYPE_COMMENT:
138
+
$tags[] = self::MAILTAG_COMMENT;
139
+
break;
138
140
case self::TYPE_TITLE:
139
-
$tags[] = self::MAILTAG_TITLE;
140
-
break;
141
141
case self::TYPE_EPOCH:
142
-
$tags[] = self::MAILTAG_EPOCH;
143
-
break;
144
142
case self::TYPE_DESCRIPTION:
145
-
$tags[] = self::MAILTAG_DESCRIPTION;
143
+
$tags[] = self::MAILTAG_DETAILS;
146
144
break;
147
145
default:
148
146
$tags[] = self::MAILTAG_OTHER;