@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Make the Diffusion warning about "svnlook" and PATH more clear
Summary:
See <https://discourse.phabricator-community.org/t/display-error-on-the-status-page-for-svn-repos/2443> for discussion.
The UI currently shows a misleading warning that looks like "found svnlook; can't find svnlook".
It actually means "found svnlook, but when Subversion wipes PATH before executing commit hooks, we will no longer be able to find it".
Test Plan: {F6240967}
Reviewers: amckinley
Reviewed By: amckinley
Differential Revision: https://secure.phabricator.com/D20210
+9
-7
+9
-7
src/applications/diffusion/management/DiffusionRepositoryBasicsManagementPanel.php
+9
-7
src/applications/diffusion/management/DiffusionRepositoryBasicsManagementPanel.php
···
444
444
id(new PHUIStatusItemView())
445
445
->setIcon(PHUIStatusItemView::ICON_WARNING, 'red')
446
446
->setTarget(
447
-
pht('Missing Binary %s', phutil_tag('tt', array(), $binary)))
448
-
->setNote(pht(
449
-
'Unable to find this binary in `%s`. '.
450
-
'You need to configure %s and include %s.',
451
-
'environment.append-paths',
452
-
$this->getEnvConfigLink(),
453
-
$path)));
447
+
pht('Commit Hooks: %s', phutil_tag('tt', array(), $binary)))
448
+
->setNote(
449
+
pht(
450
+
'The directory containing the "svnlook" binary is not '.
451
+
'listed in "environment.append-paths", so commit hooks '.
452
+
'(which execute with an empty "PATH") will not be able to '.
453
+
'find "svnlook". Add `%s` to %s.',
454
+
$path,
455
+
$this->getEnvConfigLink())));
454
456
}
455
457
}
456
458
}