@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
When changing the trigger type in the trigger editor, properly redraw the control
Summary: Ref T13269. I refactored this late in the game to organize things better and add table cells around stuff, and accidentally broke the relationship between the "Rule Type" selector and the value selector.
Test Plan: Switched rule type selector from "Change Status" to "Play Sound", saw secondary control update properly.
Reviewers: amckinley
Reviewed By: amckinley
Maniphest Tasks: T13269
Differential Revision: https://secure.phabricator.com/D20326
+5
-7
+2
-2
resources/celerity/map.php
+2
-2
resources/celerity/map.php
···
433
433
'rsrc/js/application/transactions/behavior-show-older-transactions.js' => '600f440c',
434
434
'rsrc/js/application/transactions/behavior-transaction-comment-form.js' => '2bdadf1a',
435
435
'rsrc/js/application/transactions/behavior-transaction-list.js' => '9cec214e',
436
-
'rsrc/js/application/trigger/TriggerRule.js' => 'e4a816a4',
436
+
'rsrc/js/application/trigger/TriggerRule.js' => '1c60c3fc',
437
437
'rsrc/js/application/trigger/TriggerRuleControl.js' => '5faf27b9',
438
438
'rsrc/js/application/trigger/TriggerRuleEditor.js' => 'b49fd60c',
439
439
'rsrc/js/application/trigger/TriggerRuleType.js' => '4feea7d3',
···
894
894
'syntax-default-css' => '055fc231',
895
895
'syntax-highlighting-css' => '4234f572',
896
896
'tokens-css' => 'ce5a50bd',
897
-
'trigger-rule' => 'e4a816a4',
897
+
'trigger-rule' => '1c60c3fc',
898
898
'trigger-rule-control' => '5faf27b9',
899
899
'trigger-rule-editor' => 'b49fd60c',
900
900
'trigger-rule-type' => '4feea7d3',
+3
-5
webroot/rsrc/js/application/trigger/TriggerRule.js
+3
-5
webroot/rsrc/js/application/trigger/TriggerRule.js
···
84
84
85
85
control.value = this.getType();
86
86
87
-
var on_change = JX.bind(this, this._onTypeChange);
88
-
JX.DOM.listen(control, 'onchange', null, on_change);
87
+
var on_change = JX.bind(this, this._onTypeChange, control);
88
+
JX.DOM.listen(control, 'change', null, on_change);
89
89
90
90
var attributes = {
91
91
className: 'type-cell'
···
97
97
return this._typeCell;
98
98
},
99
99
100
-
_onTypeChange: function() {
101
-
var control = this._getTypeCell();
100
+
_onTypeChange: function(control) {
102
101
this.setType(control.value);
103
-
104
102
this._rebuildValueControl();
105
103
},
106
104