recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Let PhabricatorSearchCheckboxesField survive saved query data with mismatched types

Summary:
Fixes T12851.

This should fix the error I'm seeing, which is:

* `Argument 1 passed to array_fuse() must be of the type array, boolean given`

There may be a better way to patch this up than overriding the getValue() method,
however.

Test Plan:
- Changed the default "Tags" filter to specify `true` instead of `array('self')`, then viewed that filter in the UI.
- Before patch: fatal.
- After patch: page loads. Note that `true` is not interpreted as `array('self')`, but the page isn't broken, which is a big improvement.

Reviewers: #blessed_reviewers, 20after4, chad, amckinley

Reviewed By: #blessed_reviewers, amckinley

Subscribers: Korvin

Maniphest Tasks: T12851

Differential Revision: https://secure.phabricator.com/D18132

epriestley f704f905 988a52cf

+8
+8
src/applications/search/field/PhabricatorSearchCheckboxesField.php
··· 18 18 return array(); 19 19 } 20 20 21 + protected function didReadValueFromSavedQuery($value) { 22 + if (!is_array($value)) { 23 + return array(); 24 + } 25 + 26 + return $value; 27 + } 28 + 21 29 protected function getValueFromRequest(AphrontRequest $request, $key) { 22 30 return $this->getListFromRequest($request, $key); 23 31 }