@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix regression in DiffusionDiffQueryConduitAPIMethod
Summary:
Fix the following error you may encounter in production:
Too few arguments to function DiffusionDiffQueryConduitAPIMethod::getDefaultParser(), 0 passed in /var/www/phorge/src/applications/diffusion/conduit/DiffusionDiffQueryConduitAPIMethod.php on line 156 and exactly 1 expected
It was caused by the lack of a new mandatory parameter in a method.
Closes T15649
Test Plan: Check with your big eyes that a ConduitAPIRequest is passed to getDefaultParser().
Reviewers: avivey, O1 Blessed Committers, speck
Reviewed By: O1 Blessed Committers, speck
Subscribers: speck, tobiaswiese, Matthew, Cigaryno
Maniphest Tasks: T15649
Differential Revision: https://we.phorge.it/D25444
+1
-1
+1
-1
src/applications/diffusion/conduit/DiffusionDiffQueryConduitAPIMethod.php
+1
-1
src/applications/diffusion/conduit/DiffusionDiffQueryConduitAPIMethod.php
···
153
153
$arcanist_changes = DiffusionPathChange::convertToArcanistChanges(
154
154
$path_changes);
155
155
156
-
$parser = $this->getDefaultParser();
156
+
$parser = $this->getDefaultParser($request);
157
157
$parser->setChanges($arcanist_changes);
158
158
$parser->forcePath($path->getPath());
159
159
$changes = $parser->parseDiff($raw_diff);