@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Update a straggling "getAuthorities()" call in Fund
Summary: Ref T13366. The "authorities" mechanism was replaced, but I missed this callsite. Update it to use the request cache mechanism.
Test Plan: As a user without permission to view some initiatives, viewed a list of initiatives.
Maniphest Tasks: T13366
Differential Revision: https://secure.phabricator.com/D20783
+6
-6
+6
-6
src/applications/fund/storage/FundInitiative.php
+6
-6
src/applications/fund/storage/FundInitiative.php
···
136
136
}
137
137
138
138
if ($capability == PhabricatorPolicyCapability::CAN_VIEW) {
139
-
foreach ($viewer->getAuthorities() as $authority) {
140
-
if ($authority instanceof PhortuneMerchant) {
141
-
if ($authority->getPHID() == $this->getMerchantPHID()) {
142
-
return true;
143
-
}
144
-
}
139
+
$can_merchant = PhortuneMerchantQuery::canViewersEditMerchants(
140
+
array($viewer->getPHID()),
141
+
array($this->getMerchantPHID()));
142
+
143
+
if ($can_merchant) {
144
+
return true;
145
145
}
146
146
}
147
147