@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Differential - special-case "no reviewers" warning to show only for revions that need review
Summary: 'cuz who cares unless you need review?
Test Plan: noted the UI showed up appropriately to my new business logix
Reviewers: epriestley, chad
Reviewed By: chad
CC: aran, Korvin
Maniphest Tasks: T2010
Differential Revision: https://secure.phabricator.com/D3958
+29
-17
+29
-17
src/applications/differential/controller/DifferentialRevisionViewController.php
+29
-17
src/applications/differential/controller/DifferentialRevisionViewController.php
···
137
137
}
138
138
139
139
$reviewer_warning = null;
140
-
$has_live_reviewer = false;
141
-
foreach ($revision->getReviewers() as $reviewer) {
142
-
if (!$handles[$reviewer]->isDisabled()) {
143
-
$has_live_reviewer = true;
140
+
if ($revision->getStatus() ==
141
+
ArcanistDifferentialRevisionStatus::NEEDS_REVIEW) {
142
+
$has_live_reviewer = false;
143
+
foreach ($revision->getReviewers() as $reviewer) {
144
+
if (!$handles[$reviewer]->isDisabled()) {
145
+
$has_live_reviewer = true;
146
+
break;
147
+
}
144
148
}
145
-
}
146
-
if (!$has_live_reviewer) {
147
-
$reviewer_warning = new AphrontErrorView();
148
-
$reviewer_warning->setSeverity(AphrontErrorView::SEVERITY_WARNING);
149
-
$reviewer_warning->setTitle('No Active Reviewers');
150
-
if ($revision->getReviewers()) {
151
-
$reviewer_warning->appendChild(
152
-
'<p>All specified reviewers are disabled. You may want to add '.
153
-
'some new reviewers.</p>');
154
-
} else {
155
-
$reviewer_warning->appendChild(
156
-
'<p>This revision has no specified reviewers. You may want to '.
157
-
'add some.</p>');
149
+
if (!$has_live_reviewer) {
150
+
$reviewer_warning = new AphrontErrorView();
151
+
$reviewer_warning->setSeverity(AphrontErrorView::SEVERITY_WARNING);
152
+
$reviewer_warning->setTitle('No Active Reviewers');
153
+
if ($revision->getReviewers()) {
154
+
$reviewer_warning->appendChild(
155
+
phutil_render_tag(
156
+
'p',
157
+
array(),
158
+
pht('All specified reviewers are disabled and this revision '.
159
+
'needs review. You may want to add some new reviewers.')
160
+
));
161
+
} else {
162
+
$reviewer_warning->appendChild(
163
+
phutil_render_tag(
164
+
'p',
165
+
array(),
166
+
pht('This revision has no specified reviewers and needs review.'.
167
+
' You may want to add some reviewers.')
168
+
));
169
+
}
158
170
}
159
171
}
160
172