recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix call to non-existing newEmptyValue() in PhabricatorDashboardPortalProfileMenuEngine

Summary:
`PhabricatorDashboardPortalProfileMenuEngine` calls `$this->newEmptyValue()` but neither `PhabricatorDashboardPortalProfileMenuEngine` nor its parent `PhabricatorProfileMenuEngine` define a `newEmptyValue()` method.
Thus use existing `newNoContentView()` in parent `PhabricatorProfileMenuEngine` (which according to its string output is supposed to cover this case).

Test Plan:
Go to a Portal with no content. Before applying the patch, Phorge shows the message defined in the parent class `PhabricatorProfileMenuEngine`: `No Content`; `No visible menu items can render content.`
After applying this change, it correctly shows the message defined in `PhabricatorDashboardPortalProfileMenuEngine`: `No Portal Content`; `None of the visible menu items in this portal can render any content.`

Reviewers: O1 Blessed Committers, speck

Reviewed By: O1 Blessed Committers, speck

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Differential Revision: https://we.phorge.it/D25648

Andre Klapper f8b8d887 ed9d2120

+1 -1
+1 -1
src/applications/dashboard/engine/PhabricatorDashboardPortalProfileMenuEngine.php
··· 41 41 pht('New Portal'), 42 42 pht('Use "Edit Menu" to add menu items to this portal.')); 43 43 } else { 44 - return $this->newEmptyValue( 44 + return $this->newNoContentView( 45 45 pht('No Portal Content'), 46 46 pht( 47 47 'None of the visible menu items in this portal can render any '.