recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Make Differential inline events actually trigger comment preview refreshes

Summary:
Earlier, I made some changes so that when you create or edit an inline, the comment at the bottom of the page updates (even though you didn't fiddle with the stacked actions inputs).

At the last second I broke them by spelling this wrong while cleaning things up, so they didn't actually work. Spell the property correctly ("showPreview", not "shouldPreview").

Also, we have some JS which rewrites "Not Visible" into "View", but it fires in an inconvenient way now and is flickery for me. Ideally this should get cleaned up slightly better eventualy, but at least make is stop doing so much flickery layout for now.

Test Plan:
- Wrote no comment on a revision.
- Added an inline.
- Saw comment preview properly update immediately.

Reviewers: chad

Reviewed By: chad

Differential Revision: https://secure.phabricator.com/D17229

epriestley f8cebdc4 a9158d34

+13 -13
+11 -11
resources/celerity/map.php
··· 453 453 'rsrc/js/application/search/behavior-reorder-profile-menu-items.js' => 'e2e0a072', 454 454 'rsrc/js/application/search/behavior-reorder-queries.js' => 'e9581f08', 455 455 'rsrc/js/application/slowvote/behavior-slowvote-embed.js' => '887ad43f', 456 - 'rsrc/js/application/transactions/behavior-comment-actions.js' => 'b52947eb', 456 + 'rsrc/js/application/transactions/behavior-comment-actions.js' => '9a6dd75c', 457 457 'rsrc/js/application/transactions/behavior-reorder-configs.js' => 'd7a74243', 458 458 'rsrc/js/application/transactions/behavior-reorder-fields.js' => 'b59e1e96', 459 459 'rsrc/js/application/transactions/behavior-show-older-transactions.js' => '94c65b72', ··· 609 609 'javelin-behavior-bulk-job-reload' => 'edf8a145', 610 610 'javelin-behavior-calendar-month-view' => 'fe33e256', 611 611 'javelin-behavior-choose-control' => '327a00d1', 612 - 'javelin-behavior-comment-actions' => 'b52947eb', 612 + 'javelin-behavior-comment-actions' => '9a6dd75c', 613 613 'javelin-behavior-config-reorder-fields' => 'b6993408', 614 614 'javelin-behavior-conpherence-menu' => '7524fcfa', 615 615 'javelin-behavior-conpherence-participant-pane' => '8604caa8', ··· 1682 1682 'phabricator-phtize', 1683 1683 'changeset-view-manager', 1684 1684 ), 1685 + '9a6dd75c' => array( 1686 + 'javelin-behavior', 1687 + 'javelin-stratcom', 1688 + 'javelin-workflow', 1689 + 'javelin-dom', 1690 + 'phuix-form-control-view', 1691 + 'phuix-icon-view', 1692 + 'javelin-behavior-phabricator-gesture', 1693 + ), 1685 1694 '9a8cb501' => array( 1686 1695 'aphront-typeahead-control-css', 1687 1696 'phui-tag-view-css', ··· 1855 1864 'javelin-dom', 1856 1865 'javelin-typeahead-preloaded-source', 1857 1866 'javelin-util', 1858 - ), 1859 - 'b52947eb' => array( 1860 - 'javelin-behavior', 1861 - 'javelin-stratcom', 1862 - 'javelin-workflow', 1863 - 'javelin-dom', 1864 - 'phuix-form-control-view', 1865 - 'phuix-icon-view', 1866 - 'javelin-behavior-phabricator-gesture', 1867 1867 ), 1868 1868 'b59e1e96' => array( 1869 1869 'javelin-behavior',
+1 -1
src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php
··· 270 270 ), 271 271 'sigil' => 'differential-inline-preview-jump', 272 272 ), 273 - pht('Not Visible')); 273 + pht('View')); 274 274 275 275 $action_buttons[] = id(new PHUIButtonView()) 276 276 ->setTag('a')
+1 -1
webroot/rsrc/js/application/transactions/behavior-comment-actions.js
··· 126 126 } 127 127 128 128 function force_preview() { 129 - if (!config.shouldPreview) { 129 + if (!config.showPreview) { 130 130 return; 131 131 } 132 132