recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Add flexible line height to remarkup headers

Summary:
The text in remarkup has a fixed line height. The headers will have the same fixed line height, even if their font size can be bigger than this line height. Especially on mobile this results in ugly sticked together lines which are less readable.

This revision will give the header a flexible line height of `1.3`. Unitless means relative to the font size.

| Before | After |
|-----------|-----------|
| {F717418} | {F717419} |

(I have moved the same margin attribute for every `h{2-6}` into the new declaration.)

Close T15716.

Test Plan: Just checkout and look in wiki articles with headers to see if everything looks nice and neat.

Reviewers: O1 Blessed Committers, 20after4

Reviewed By: O1 Blessed Committers, 20after4

Subscribers: 20after4, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15716

Differential Revision: https://we.phorge.it/D25523

Benjamin Kausch f8db94f2 6a30dc03

+8 -8
+3 -3
resources/celerity/map.php
··· 9 9 'names' => array( 10 10 'conpherence.pkg.css' => '2f25eb4f', 11 11 'conpherence.pkg.js' => '020aebcf', 12 - 'core.pkg.css' => '4e0e22fb', 12 + 'core.pkg.css' => 'c753df75', 13 13 'core.pkg.js' => '2eeda9e0', 14 14 'dark-console.pkg.js' => '187792c2', 15 15 'differential.pkg.css' => '2431def2', ··· 109 109 'rsrc/css/application/tokens/tokens.css' => 'ce5a50bd', 110 110 'rsrc/css/application/uiexample/example.css' => 'b4795059', 111 111 'rsrc/css/core/core.css' => 'b3a5928e', 112 - 'rsrc/css/core/remarkup.css' => 'b251d2e7', 112 + 'rsrc/css/core/remarkup.css' => 'd91c2ee8', 113 113 'rsrc/css/core/syntax.css' => '548567f6', 114 114 'rsrc/css/core/z-index.css' => 'ac3bfcd4', 115 115 'rsrc/css/diviner/diviner-shared.css' => '4bd263b0', ··· 798 798 'phabricator-object-selector-css' => 'ee77366f', 799 799 'phabricator-phtize' => '2f1db1ed', 800 800 'phabricator-prefab' => '5793d835', 801 - 'phabricator-remarkup-css' => 'b251d2e7', 801 + 'phabricator-remarkup-css' => 'd91c2ee8', 802 802 'phabricator-remarkup-metadata' => 'e40c4991', 803 803 'phabricator-search-results-css' => '9ea70ace', 804 804 'phabricator-shaped-request' => '995f5102',
+5 -5
webroot/rsrc/css/core/remarkup.css
··· 174 174 list-style-type: none; 175 175 } 176 176 177 + .phabricator-remarkup .remarkup-header { 178 + line-height: 1.4; 179 + margin: 1em 0 0.75em; 180 + } 181 + 177 182 .phabricator-remarkup h2.remarkup-header { 178 183 font-size: 28px; 179 - margin: 1em 0 0.75em; 180 184 } 181 185 182 186 .phabricator-remarkup h3.remarkup-header { 183 187 font-size: 24px; 184 - margin: 1em 0 0.75em; 185 188 } 186 189 187 190 .phabricator-remarkup h4.remarkup-header { 188 191 font-size: 22px; 189 - margin: 1em 0 0.75em; 190 192 } 191 193 192 194 .phabricator-remarkup h5.remarkup-header { 193 195 font-size: 18px; 194 - margin: 1em 0 0.75em; 195 196 } 196 197 197 198 .phabricator-remarkup h6.remarkup-header { 198 199 font-size: 16px; 199 - margin: 1em 0 0.75em; 200 200 } 201 201 202 202 .phabricator-remarkup blockquote {