@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
In "Move Tasks to Column...", show only visible columns
Summary:
See PHI94. I considered this initially but wasn't sure about it. However, PHI94 brings up the good point that we already use a similar rule in Maniphest.
For consistency, only show visible columns here too.
Test Plan: Used "Move tasks to column..." on a board with visible and hidden columns, only saw visbile columns offered in the dropdown.
Reviewers: amckinley
Reviewed By: amckinley
Differential Revision: https://secure.phabricator.com/D18668
+6
+6
src/applications/project/controller/PhabricatorProjectBoardViewController.php
+6
src/applications/project/controller/PhabricatorProjectBoardViewController.php
···
313
313
$columns = $move_engine->getColumns($move_project->getPHID());
314
314
$columns = mpull($columns, null, 'getPHID');
315
315
316
+
foreach ($columns as $key => $column) {
317
+
if ($column->isHidden()) {
318
+
unset($columns[$key]);
319
+
}
320
+
}
321
+
316
322
$move_column_phid = $request->getStr('moveColumnPHID');
317
323
if (!$move_column_phid) {
318
324
if ($request->getBool('hasColumn')) {