@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Allow lightbox comments to be viewed logged out
Summary: Fixes T12160. Lightbox thread view should be visible if file is public.
Test Plan:
Add a file to a task, log out, click on file in task, get lightbox and no error. Expand comments, see login box.
{F2867067}
{F2867088}
{F2867098}
{F2867114}
{F2867124}
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Maniphest Tasks: T12160
Differential Revision: https://secure.phabricator.com/D17347
+4
+4
src/applications/files/controller/PhabricatorFileLightboxController.php
+4
src/applications/files/controller/PhabricatorFileLightboxController.php
···
3
3
final class PhabricatorFileLightboxController
4
4
extends PhabricatorFileController {
5
5
6
+
public function shouldAllowPublic() {
7
+
return true;
8
+
}
9
+
6
10
public function handleRequest(AphrontRequest $request) {
7
11
$viewer = $request->getViewer();
8
12
$phid = $request->getURIData('phid');