recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Remove "Used By" from Passphrase

Summary: Fixes T10972. Nothing actually updates this anymore, and only repositories ever did (e.g., Harbormaster and Drydock have never tracked it). Keeping track of this is more trouble than it's worth.

Test Plan: Grepped for constants, viewed a passphrase credential.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10972

Differential Revision: https://secure.phabricator.com/D15932

epriestley f930a43f 174f3f6d

-46
-4
src/__phutil_library_map__.php
··· 2166 2166 'PhabricatorCountdownTransactionQuery' => 'applications/countdown/query/PhabricatorCountdownTransactionQuery.php', 2167 2167 'PhabricatorCountdownView' => 'applications/countdown/view/PhabricatorCountdownView.php', 2168 2168 'PhabricatorCountdownViewController' => 'applications/countdown/controller/PhabricatorCountdownViewController.php', 2169 - 'PhabricatorCredentialsUsedByObjectEdgeType' => 'applications/passphrase/edge/PhabricatorCredentialsUsedByObjectEdgeType.php', 2170 2169 'PhabricatorCursorPagedPolicyAwareQuery' => 'infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php', 2171 2170 'PhabricatorCustomField' => 'infrastructure/customfield/field/PhabricatorCustomField.php', 2172 2171 'PhabricatorCustomFieldAttachment' => 'infrastructure/customfield/field/PhabricatorCustomFieldAttachment.php', ··· 2807 2806 'PhabricatorObjectQuery' => 'applications/phid/query/PhabricatorObjectQuery.php', 2808 2807 'PhabricatorObjectRemarkupRule' => 'infrastructure/markup/rule/PhabricatorObjectRemarkupRule.php', 2809 2808 'PhabricatorObjectSelectorDialog' => 'view/control/PhabricatorObjectSelectorDialog.php', 2810 - 'PhabricatorObjectUsesCredentialsEdgeType' => 'applications/transactions/edges/PhabricatorObjectUsesCredentialsEdgeType.php', 2811 2809 'PhabricatorOffsetPagedQuery' => 'infrastructure/query/PhabricatorOffsetPagedQuery.php', 2812 2810 'PhabricatorOldWorldContentSource' => 'infrastructure/contentsource/PhabricatorOldWorldContentSource.php', 2813 2811 'PhabricatorOneTimeTriggerClock' => 'infrastructure/daemon/workers/clock/PhabricatorOneTimeTriggerClock.php', ··· 6656 6654 'PhabricatorCountdownTransactionQuery' => 'PhabricatorApplicationTransactionQuery', 6657 6655 'PhabricatorCountdownView' => 'AphrontView', 6658 6656 'PhabricatorCountdownViewController' => 'PhabricatorCountdownController', 6659 - 'PhabricatorCredentialsUsedByObjectEdgeType' => 'PhabricatorEdgeType', 6660 6657 'PhabricatorCursorPagedPolicyAwareQuery' => 'PhabricatorPolicyAwareQuery', 6661 6658 'PhabricatorCustomField' => 'Phobject', 6662 6659 'PhabricatorCustomFieldAttachment' => 'Phobject', ··· 7381 7378 'PhabricatorObjectQuery' => 'PhabricatorCursorPagedPolicyAwareQuery', 7382 7379 'PhabricatorObjectRemarkupRule' => 'PhutilRemarkupRule', 7383 7380 'PhabricatorObjectSelectorDialog' => 'Phobject', 7384 - 'PhabricatorObjectUsesCredentialsEdgeType' => 'PhabricatorEdgeType', 7385 7381 'PhabricatorOffsetPagedQuery' => 'PhabricatorQuery', 7386 7382 'PhabricatorOldWorldContentSource' => 'PhabricatorContentSource', 7387 7383 'PhabricatorOneTimeTriggerClock' => 'PhabricatorTriggerClock',
-10
src/applications/passphrase/controller/PassphraseCredentialViewController.php
··· 202 202 $credential->getUsername()); 203 203 } 204 204 205 - $used_by_phids = PhabricatorEdgeQuery::loadDestinationPHIDs( 206 - $credential->getPHID(), 207 - PhabricatorCredentialsUsedByObjectEdgeType::EDGECONST); 208 - 209 - if ($used_by_phids) { 210 - $properties->addProperty( 211 - pht('Used By'), 212 - $viewer->renderHandleList($used_by_phids)); 213 - } 214 - 215 205 $description = $credential->getDescription(); 216 206 if (strlen($description)) { 217 207 $properties->addSectionHeader(
-16
src/applications/passphrase/edge/PhabricatorCredentialsUsedByObjectEdgeType.php
··· 1 - <?php 2 - 3 - final class PhabricatorCredentialsUsedByObjectEdgeType 4 - extends PhabricatorEdgeType { 5 - 6 - const EDGECONST = 40; 7 - 8 - public function getInverseEdgeConstant() { 9 - return PhabricatorObjectUsesCredentialsEdgeType::EDGECONST; 10 - } 11 - 12 - public function shouldWriteInverseTransactions() { 13 - return true; 14 - } 15 - 16 - }
-16
src/applications/transactions/edges/PhabricatorObjectUsesCredentialsEdgeType.php
··· 1 - <?php 2 - 3 - final class PhabricatorObjectUsesCredentialsEdgeType 4 - extends PhabricatorEdgeType { 5 - 6 - const EDGECONST = 39; 7 - 8 - public function getInverseEdgeConstant() { 9 - return PhabricatorCredentialsUsedByObjectEdgeType::EDGECONST; 10 - } 11 - 12 - public function shouldWriteInverseTransactions() { 13 - return true; 14 - } 15 - 16 - }