@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Correct behavior of "writable" Almanac service binding for repository services

Summary: Ref T13611. This property worked correctly when implemented in D19357. The behavior was broken by D20775, which tested node-level routing but did not specifically re-test the "writable" property. This was difficult to spot because ref query outcomes weren't observable in the UI, and the ref itself had the correct property value.

Test Plan:
See D21575. After this change, the UI shows the correct state, rather than showing a read-only service ref as writable:

{F8465865}

Maniphest Tasks: T13611

Differential Revision: https://secure.phabricator.com/D21576

+1 -1
+1 -1
src/applications/repository/storage/PhabricatorRepository.php
··· 1975 1975 if ($writable) { 1976 1976 foreach ($refs as $key => $ref) { 1977 1977 if (!$ref->isWritable()) { 1978 - unset($results[$key]); 1978 + unset($refs[$key]); 1979 1979 } 1980 1980 } 1981 1981